After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 662394 - WindowManager.js: _shouldAnimate : function(actor) checks against wrong variable
WindowManager.js: _shouldAnimate : function(actor) checks against wrong variable
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: general
3.2.x
Other Linux
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2011-10-21 15:17 UTC by fry
Modified: 2011-11-08 00:59 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Patch (898 bytes, patch)
2011-10-21 16:03 UTC, fry 		needs-work Details | Review
[PATCH] window-manager: Fix variable name (909 bytes, patch)
2011-10-24 09:45 UTC, fry 		committed Details | Review

Description fry 2011-10-21 15:17:06 UTC 
In file gnome-shell/js/ui/windowManager.js:


_shouldAnimate : function(actor)
        if (Main.overview.visible || this._animationsBlocked > 0)
[...]

Variable _animationsBlocked does not exist. Correct check should be:

_shouldAnimate : function(actor) {
    if (Main.overview.visible || this._animationBlockCount > 0)
[...]
Comment 1 Florian Müllner 2011-10-21 15:26:45 UTC 
Good catch - can you attach a git-format'ed patch?
Comment 2 fry 2011-10-21 16:03:46 UTC 
Created attachment 199664 [details] [review]
Patch

Here you go!
Comment 3 Florian Müllner 2011-10-21 16:17:26 UTC 
Review of attachment 199664 [details] [review]:

Looks good, thanks!

However, git.gnome.org requires a valid email address to push. Also the commit message could be improved, I'd suggest something along the lines of

window-manager: Fix variable name
    
In _shouldAnimate() _animationBlockCount was referred to as
_animationsBlocked, fix this.
    
https://bugzilla.gnome.org/show_bug.cgi?id=662394
Comment 4 fry 2011-10-24 09:45:35 UTC 
Created attachment 199805 [details] [review]
[PATCH] window-manager: Fix variable name

I hope this one works ;)
Comment 5 Florian Müllner 2011-11-08 00:58:44 UTC 
(In reply to comment #4)
> I hope this one works ;)

Indeed, thanks again for the patch!