After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 662152 - Use the generic marshaller
Use the generic marshaller
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2011-10-18 23:41 UTC by Jasper St. Pierre (not reading bugmail)
Modified: 2012-01-26 00:05 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
st: Use generic marshaller (10.38 KB, patch)
2011-10-18 23:41 UTC, Jasper St. Pierre (not reading bugmail)
committed Details | Review
etc: Use generic marshaller (9.25 KB, patch)
2011-10-18 23:41 UTC, Jasper St. Pierre (not reading bugmail)
committed Details | Review
shell: Use generic marshaller (18.95 KB, patch)
2011-10-18 23:41 UTC, Jasper St. Pierre (not reading bugmail)
committed Details | Review

Description Jasper St. Pierre (not reading bugmail) 2011-10-18 23:41:39 UTC
genmarshal.pl and other things are deprecated and there's no sense using them now.

Includes patches for the egg-style 'gvc' and 'na-tray' libs. Not sure where the upstream for them is.
Comment 1 Jasper St. Pierre (not reading bugmail) 2011-10-18 23:41:41 UTC
Created attachment 199376 [details] [review]
st: Use generic marshaller
Comment 2 Jasper St. Pierre (not reading bugmail) 2011-10-18 23:41:44 UTC
Created attachment 199377 [details] [review]
etc: Use generic marshaller
Comment 3 Jasper St. Pierre (not reading bugmail) 2011-10-18 23:41:47 UTC
Created attachment 199378 [details] [review]
shell: Use generic marshaller
Comment 4 Owen Taylor 2012-01-25 17:19:50 UTC
Review of attachment 199376 [details] [review]:

Looks fine
Comment 5 Owen Taylor 2012-01-25 17:21:17 UTC
Review of attachment 199377 [details] [review]:

You can't use 'etc' as indicating a component of gnome-shell, so fix the Subject:, otherwise OK
Comment 6 Owen Taylor 2012-01-25 17:22:45 UTC
Review of attachment 199378 [details] [review]:

Looks OK
Comment 7 Jasper St. Pierre (not reading bugmail) 2012-01-26 00:04:37 UTC
Attachment 199376 [details] pushed as 78fb102 - st: Use generic marshaller
Attachment 199377 [details] pushed as 46505a8 - etc: Use generic marshaller
Attachment 199378 [details] pushed as b40b199 - shell: Use generic marshaller
Comment 8 Jasper St. Pierre (not reading bugmail) 2012-01-26 00:05:07 UTC
Er, whoops, forgot about the "etc" commit message change before pushing.