After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 661869 - Display words on po file statistics pages
Display words on po file statistics pages
Status: RESOLVED FIXED
Product: damned-lies
Classification: Infrastructure
Component: general
unspecified
Other Linux
: Normal enhancement
: ---
Assigned To: damned-lies Maintainer(s)
damned-lies Maintainer(s)
: 656969 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2011-10-15 22:11 UTC by Gil Forcada
Modified: 2011-10-21 15:25 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
(1/7) Show POT total words next to total strings (2.71 KB, patch)
2011-10-15 22:12 UTC, Gil Forcada 		accepted-commit_now Details | Review
(2/7) Just make one call to pot_size on PoFile.{tr,fu,un}_percentage methods (1.48 KB, patch)
2011-10-15 22:13 UTC, Gil Forcada 		accepted-commit_now Details | Review
(3/7) Added PoFile.{tr,fu,un}_word_percentage methods cloning PoFile.{tr,fu,un}_percentage ones (1.77 KB, patch)
2011-10-15 22:14 UTC, Gil Forcada 		accepted-commit_now Details | Review
(4/7) Added word statis variables and methods to FakeSummaryStatistics class (1.29 KB, patch)
2011-10-15 22:16 UTC, Gil Forcada 		accepted-commit_now Details | Review
(5/7) More word methods. Now on Statistics class: {translated,fuzzy,untranslated}_words and {tr,fu,un}_word_percentage methods (2.97 KB, patch)
2011-10-15 22:17 UTC, Gil Forcada 		accepted-commit_now Details | Review
(6/7) Registered the filters for word po file statistics (3.29 KB, patch)
2011-10-15 22:19 UTC, Gil Forcada 		accepted-commit_now Details | Review
(7/7) Finally update the template and CSS to show the word statistics on the PO file details (2.70 KB, patch)
2011-10-15 22:20 UTC, Gil Forcada 		accepted-commit_now Details | Review
Screenshot showing how the words statistics are displayed (114.10 KB, image/png)
2011-10-15 22:22 UTC, Gil Forcada 		  Details
Screenshot showing how the word statistics are displayed on the documentation (114.10 KB, image/png)
2011-10-15 22:23 UTC, Gil Forcada 		  Details
Screenshot showing how the word statistics are displayed on the documentation (103.23 KB, image/png)
2011-10-16 09:03 UTC, Gil Forcada 		  Details

Description Gil Forcada 2011-10-15 22:11:30 UTC 
Finally I got some time to make the August work (adding word support on statistics) useful :)

See attached 7 patches (one of them can be applied alone) and 2 screenshots of the results.

Cheers,
Comment 1 Gil Forcada 2011-10-15 22:12:46 UTC 
Created attachment 199082 [details] [review]
(1/7) Show POT total words next to total strings
Comment 2 Gil Forcada 2011-10-15 22:13:59 UTC 
Created attachment 199083 [details] [review]
(2/7) Just make one call to pot_size on PoFile.{tr,fu,un}_percentage methods

That's the one that can be applied alone
Comment 3 Gil Forcada 2011-10-15 22:14:55 UTC 
Created attachment 199085 [details] [review]
(3/7) Added PoFile.{tr,fu,un}_word_percentage methods cloning PoFile.{tr,fu,un}_percentage ones
Comment 4 Gil Forcada 2011-10-15 22:16:05 UTC 
Created attachment 199086 [details] [review]
(4/7) Added word statis variables and methods to FakeSummaryStatistics class
Comment 5 Gil Forcada 2011-10-15 22:17:02 UTC 
Created attachment 199087 [details] [review]
(5/7) More word methods. Now on Statistics class: {translated,fuzzy,untranslated}_words and {tr,fu,un}_word_percentage methods
Comment 6 Gil Forcada 2011-10-15 22:19:15 UTC 
Created attachment 199088 [details] [review]
(6/7) Registered the filters for word po file statistics
Comment 7 Gil Forcada 2011-10-15 22:20:06 UTC 
Created attachment 199089 [details] [review]
(7/7) Finally update the template and CSS to show the word statistics on the PO file details
Comment 8 Gil Forcada 2011-10-15 22:22:02 UTC 
Created attachment 199090 [details]
Screenshot showing how the words statistics are displayed
Comment 9 Gil Forcada 2011-10-15 22:23:06 UTC 
Created attachment 199091 [details]
Screenshot showing how the word statistics are displayed on the documentation
Comment 10 Gil Forcada 2011-10-16 09:03:08 UTC 
Created attachment 199108 [details]
Screenshot showing how the word statistics are displayed on the documentation

Sorry I uploaded the same image twice. This was the other screenshot I wanted to upload.
Comment 11 Claude Paroz 2011-10-21 09:00:19 UTC 
Review of attachment 199088 [details] [review]:

A little too much code redundancy, but well some refactoring might be applied later.
Comment 12 Claude Paroz 2011-10-21 09:02:55 UTC 
Thanks Gil for this work, and for the care you took in separating patches.
Comment 13 Gil Forcada 2011-10-21 14:42:43 UTC 
I usually do lots of small commits and "git rebase -i" them all the time.

Thanks a lot for reviewing them!

Pushed!!
Comment 14 Gil Forcada 2011-10-21 14:43:48 UTC 
*** Bug 656969 has been marked as a duplicate of this bug. ***
Comment 15 Claude Paroz 2011-10-21 15:25:49 UTC 
This is now in production.