GNOME Bugzilla – Bug 661615
messageTray: Fix scrolling up in the message tray
Last modified: 2012-05-02 20:13:43 UTC
Letting them fight with each other isn't really a good idea... it's the reason that you can't scroll down after scrolling a notification up in the summary view. Note: the behavior you see here is hard to describe, so I highly recommend trying it out for yourself. Pasting the first paragraph of The Declaration of Independence into notify-send gave me a long enough message to test with.
Created attachment 198891 [details] [review] messageTray: Remove scrollArea We already use a ScrollView for the notifications stack, and fighing with it for scroll events isn't really a good idea.
Created attachment 198892 [details] [review] messageTray: notification should be a style class name, not a global name There have been multiple notifications ever since we had a notification stack per source, so the idea of one notification being on screen at a time has long been dead.
Created attachment 198896 [details] [review] messageTray: Remove scrollArea We already use a ScrollView for the notifications stack, and fighing with it for scroll events isn't really a good idea. -- Needs the fix from bug #661617 to fix a crash. Fixes an issue with reparenting the notification to put it in the summary item stack.
Created attachment 199874 [details] [review] messageTray: notification should be a style class name, not a global name There have been multiple notifications ever since we had a notification stack per source, so the idea of one notification being on screen at a time has long been dead.
Created attachment 199875 [details] [review] messageTray: disable scrolling for real You could scroll up, but not down, while in a stack view. This was because of some silly StAdjustment shenanigans that isn't particularily important. Just disable mouse wheel scrolling when we're in a stack view. This is a much easier, less breaky, alternate solution.
*** Bug 665363 has been marked as a duplicate of this bug. ***
Ping on this?
Review of attachment 199874 [details] [review]: Makes sense.
Review of attachment 199875 [details] [review]: Code is fine and works but the commit message is rather confusing you should note that we have nested scrollviews and that we disable the mousewheel scrolling for the notifications rather then the whole stack.
Attachment 199874 [details] pushed as 399df66 - messageTray: notification should be a style class name, not a global name Pushed with modified commit message.