After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 661494 - shell: Avoid crash when searching if a .desktop has no comment
shell: Avoid crash when searching if a .desktop has no comment
Status: RESOLVED FIXED
Product: gnome-control-center
Classification: Core
Component: shell
unspecified
Other All
: Normal normal
: ---
Assigned To: Control-Center Maintainers
Control-Center Maintainers
Depends on:
Blocks:
 
 
Reported: 2011-10-11 21:13 UTC by Vincent Untz
Modified: 2011-10-12 15:15 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
shell: Avoid crash when searching if a .desktop has no comment (1.25 KB, patch)
2011-10-11 21:13 UTC, Vincent Untz 		committed Details | Review

Description Vincent Untz 2011-10-11 21:13:37 UTC 
The search render is something I re-use outside of the control center (downstream), but it assumes that the description column is always set, which might not be the case if a .desktop has no comment.

Since the fix is easy and makes sense, it'd be nice to have it upstream.
Comment 1 Vincent Untz 2011-10-11 21:13:39 UTC 
Created attachment 198815 [details] [review]
shell: Avoid crash when searching if a .desktop has no comment

The code doing the search assumes the description column is set, which
might not be the case.
Comment 2 Bastien Nocera 2011-10-12 15:15:07 UTC 
Attachment 198815 [details] pushed as 80bd53c - shell: Avoid crash when searching if a .desktop has no comment