After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 661088 - gnome-session 3.2.0 crashes
gnome-session 3.2.0 crashes
Status: RESOLVED FIXED
Product: gnome-session
Classification: Core
Component: gnome-session
3.2.x
Other Solaris
: Normal normal
: ---
Assigned To: Session Maintainers
Session Maintainers
Depends on:
Blocks:
 
 
Reported: 2011-10-06 14:53 UTC by Brian Cameron
Modified: 2011-10-07 09:23 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
patch fixing issue (559 bytes, patch)
2011-10-06 14:53 UTC, Brian Cameron 		reviewed Details | Review

Description Brian Cameron 2011-10-06 14:53:35 UTC 
Created attachment 198436 [details] [review]
patch fixing issue

On Solaris, I find that gnome-session 3.2.0 crashes after I have logged in for about 30-60 seconds or so.  The crash happens in this code in gsm-shell-extensions.c:

-  while (schemas != '\0')
     {
       if (g_str_equal (*schemas, SHELL_SCHEMA))

The crash happens in the call to g_str_equal when schemas is NULL.  I find that changing the code as in the attached patch fixes this problem.
Comment 1 Vincent Untz 2011-10-06 15:01:36 UTC 
Review of attachment 198436 [details] [review]:

::: gnome-session-3.2.0/gnome-session/gsm-shell-extensions.c-orig
@@ +257,3 @@
    * for the existance of a schema, so hack around it. */
   schemas = g_settings_list_schemas ();
+  while (schemas != NULL && schemas != '\0')

The "schemas != '\0'" part sounds wrong anyway. Can you drop it and if it still works, commit?
Comment 2 Brian Cameron 2011-10-07 08:07:44 UTC 
I removed the "schemas != '\0'" part and that also avoids the crash.

I am really hectic busy the next couple of weeks.  Could a maintainer commit this very minor patch for me?
Comment 3 Vincent Untz 2011-10-07 09:23:21 UTC 
Fix pushed.