After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 661031 - --disable-deprecations configure option doesn't drop deprecation flags
--disable-deprecations configure option doesn't drop deprecation flags
Status: RESOLVED FIXED
Product: file-roller
Classification: Applications
Component: general
2.32.x
Other Linux
: Normal normal
: ---
Assigned To: Paolo Bacchilega
file-roller-maint
Depends on:
Blocks:
 
 
Reported: 2011-10-05 21:58 UTC by Pacho Ramos
Modified: 2013-08-18 13:21 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
config.log (35.01 KB, text/plain)
2011-10-05 21:58 UTC, Pacho Ramos 		  Details
Use $(DISABLE_DEPRECATED) in copy-n-paste/Makefile.am (880 bytes, patch)
2011-10-09 22:18 UTC, Andreas Henriksson 		committed Details | Review

Description Pacho Ramos 2011-10-05 21:58:38 UTC 
Created attachment 198383 [details]
config.log

As reported downstream at:
https://bugs.gentoo.org/show_bug.cgi?id=385453

DEPRECATION flags are still being used even with --disable-deprecations configure option being passed
Comment 1 Andreas Henriksson 2011-10-09 22:18:35 UTC 
Created attachment 198676 [details] [review]
Use $(DISABLE_DEPRECATED) in copy-n-paste/Makefile.am

Take the --disable-deprecated configure flag into account instead
of just always disabling deprecated code in copy-n-paste/.
Comment 2 Paolo Bacchilega 2011-10-10 09:31:18 UTC 
Patch applied to master, thanks.

As for the main problem, in version 3.2 if you pass --disable-deprecated to configure, the DISABLE_DEPRECATED macros are defined and this is the way it is supposed to work, if you want to enable the use of depecrated code don't use the --disable-deprecated option or pass --disable-deprecated=no.
Comment 3 Andreas Henriksson 2012-10-10 11:36:27 UTC 
Comment on attachment 198676 [details] [review]
Use $(DISABLE_DEPRECATED) in copy-n-paste/Makefile.am

http://git.gnome.org/browse/file-roller/commit/copy-n-paste/Makefile.am?id=83ab53d16213fa79baad17ee63290287c708b0cf
Comment 4 Paolo Bacchilega 2013-08-18 13:21:10 UTC 
forgot to close...