After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 661015 - Add clutter_unicode_to_keyval function
Add clutter_unicode_to_keyval function
Status: RESOLVED FIXED
Product: clutter
Classification: Platform
Component: general
git master
Other Linux
: Normal normal
: ---
Assigned To: clutter-maint
clutter-maint
Depends on:
Blocks:
 
 
Reported: 2011-10-05 19:13 UTC by Zan Dobersek
Modified: 2011-10-07 11:14 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Add clutter_unicode_to_keyval (64.74 KB, patch)
2011-10-05 19:24 UTC, Zan Dobersek
committed Details | Review

Description Zan Dobersek 2011-10-05 19:13:52 UTC
I'd like to propose adding clutter_unicode_to_keyval function to Clutter.

The need comes from the efforts of porting the WebKit layout engine to Clutter. More specifically, this function is particularly needed for testing purposes when key events with various key values are simulated. Very often in WebKit's large test suite the key value is presented as a unicode character that then needs to be converted into a proper key value. The testing platform would benefit immensely from availability of this function.

Already available is the clutter_keyval_to_unicode function that is practically identical to gdk_keysym_to_unicode. In the following patch I will add the unicode-to-keysym conversion table and the appropriate function, both being based on the gdk versions of the same objects.
Comment 1 Zan Dobersek 2011-10-05 19:24:35 UTC
Created attachment 198366 [details] [review]
Add clutter_unicode_to_keyval

This patch adds the said function and the necessary conversion table, all based on the GDK versions of both these objects.
Comment 2 Emmanuele Bassi (:ebassi) 2011-10-06 12:48:47 UTC
Review of attachment 198366 [details] [review]:

looks good to me.
Comment 3 Emmanuele Bassi (:ebassi) 2011-10-07 11:14:00 UTC
attachment 198366 [details] [review] pushed to master