GNOME Bugzilla – Bug 660816
dvd menus got broken
Last modified: 2011-10-25 08:00:52 UTC
Some changes in the last cycle broke the menu navigation for at least one DVD I have. After choosing the chapter-selection nothing happens and upon another click anywhere the first chapter plays. This make it impossible to play the remaining chapters.
You're talking about a regression in git I presume? *** This bug has been marked as a duplicate of bug 657261 ***
Just went back release by release for ugly down to RELEASE-0.10.16 and still facing the same issues :/
That's not entirely unexpected, since resindvd lives in -bad :)
Unlike in Bug 657261, for me the button action does not work. I am not getting to the menu. Thats the last log I see: 0:00:14.875790306 23353 0x2823a90 INFO rsndvddemux gstmpegdemux.c:794:gst_flups_demux_handle_dvd_event:<dvddemux> Have DVD audio stream select event: stream 0x80 Whats weird too is that in totem "go to DVD menu" play the first track. While "go to title menu" works as expected and goes to where the dvd also starts. "next/prev chapter movie" just stops. This was on a thomas & frieds dvd - yes, family pressure :/ Will test other DVDs too
Does reverting 2f8467d68249e8d1a28b7bbd9c53b56a8c26ba4b and 105da803ade859fb299ed3c5265d6acdd168ca8f make it work ?
Or, easier tested, does checkout of 105da803ade859fb299ed3c5265d6acdd168ca8f^ make it work, and checkout of 0e9203df11fbfaf0955c5f37537a93701d67aeb6 makes it break ?
105da803ade859fb299ed3c5265d6acdd168ca8f does not seem to reference a commit in gst-plugin-bad.
Indeed, it's in -good.
Actually its in base and yes at 105da803ade859fb299ed3c5265d6acdd168ca8f^ it works and at 0e9203df11fbfaf0955c5f37537a93701d67aeb6 its broken
Created attachment 198435 [details] [review] playsink: fix caps negotiation through the new convenience bins The bins' getcaps was bypassing the inner elements, and thus failing to account for the caps transformations they allow, which caused YUV video pipelines to fail with ximagesink, which does not support YUV, even though the convenience bin includes a colorspace converter for just this purpose.
You probably also want my fix for https://bugzilla.gnome.org/show_bug.cgi?id=657261 which makes menu highlights work again.
*** Bug 656665 has been marked as a duplicate of this bug. ***
The pad blocked callback temporarily disconnects the ghost pads, so I'll need to add some locking around it, as someone else is getting NULL pointers from there from time to time.
Comment on attachment 198435 [details] [review] playsink: fix caps negotiation through the new convenience bins Works great, please push!
commit 8d617f403769f4f2519de72c3d7e267ee850b123 Author: Vincent Penquerc'h <vincent.penquerch@collabora.co.uk> Date: Thu Oct 6 15:38:49 2011 +0100 playsink: fix caps negotiation through the new convenience bins The bins' getcaps was bypassing the inner elements, and thus failing to account for the caps transformations they allow, which caused YUV video pipelines to fail with ximagesink, which does not support YUV, even though the convenience bin includes a colorspace converter for just this purpose. https://bugzilla.gnome.org/show_bug.cgi?id=660816
(In reply to comment #13) > The pad blocked callback temporarily disconnects the ghost pads, so I'll need > to add some locking around it, as someone else is getting NULL pointers from > there from time to time. I do get NULL poitner very often, this is due to a bug in the ghost_pad_target implementation. I'm currently working on that (see bug 658517). Take note that this patch is not correct. Getting the peer of the target will reverse the direction. Instead you should simply call getcaps ont he target. Actually, gst_proxy_pad_getcaps_default() will do the right thing, no need to implement our own here. I'll post a patch as soon as the other fix is pushed.
See https://bugzilla.gnome.org/show_bug.cgi?id=661262 for further patches that (should) fix the issue.