After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 660778 - multiqueue: check filled state of queues even if another one is empty
multiqueue: check filled state of queues even if another one is empty
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gstreamer (core)
unspecified
Other All
: Normal normal
: 0.10.36
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks: 563827 659924
 
 
Reported: 2011-10-03 11:35 UTC by Vincent Penquerc'h
Modified: 2011-11-24 09:39 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
multiqueue: check filled state of queues even if another one is empty (1.29 KB, patch)
2011-10-03 11:35 UTC, Vincent Penquerc'h 		committed Details | Review

Description Vincent Penquerc'h 2011-10-03 11:35:54 UTC 
This will avoid a case where overrun is never signalled if some
stream never produces any data, causing playbin2 to not end preroll.
Comment 1 Vincent Penquerc'h 2011-10-03 11:35:56 UTC 
Created attachment 198072 [details] [review]
multiqueue: check filled state of queues even if another one is empty
Comment 2 Vincent Penquerc'h 2011-10-03 11:36:59 UTC 
I am not totally sure this will not cause unintended side effects, so if someone knows well decodebin2 and/or multiqueue, a once over would be appreciated.
Comment 3 Vincent Penquerc'h 2011-10-18 17:31:18 UTC 
This patch has been in use for a small while now at Onelan (using playbin2), so no obvious problems with it.
Comment 4 Sebastian Dröge (slomo) 2011-11-24 09:38:50 UTC 
commit 611ac6ea854733a7745a2f15428ae89eccaa0ff2
Author: Vincent Penquerc'h <vincent.penquerch@collabora.co.uk>
Date:   Mon Oct 3 12:34:20 2011 +0100

    multiqueue: check filled state of queues even if another one is empty
    
    This will avoid a case where overrun is never signalled if some
    stream never produces any data, causing playbin2 to not end preroll.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=660778