After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 660623 - clutter-actor-meta: Fix _clutter_meta_group_has_metas_no_internal
clutter-actor-meta: Fix _clutter_meta_group_has_metas_no_internal
Status: RESOLVED FIXED
Product: clutter
Classification: Platform
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: clutter-maint
clutter-maint
Depends on:
Blocks:
 
 
Reported: 2011-10-01 10:39 UTC by drago01
Modified: 2011-10-01 11:10 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
clutter-actor-meta: Fix _clutter_meta_group_has_metas_no_internal (1.43 KB, patch)
2011-10-01 10:39 UTC, drago01
none Details | Review
clutter-actor-meta: Fix _clutter_meta_group_has_metas_no_internal (1.43 KB, patch)
2011-10-01 10:40 UTC, drago01
committed Details | Review

Description drago01 2011-10-01 10:39:05 UTC
I have messed up ....  see patch for fix.
Comment 1 drago01 2011-10-01 10:39:07 UTC
Created attachment 197954 [details] [review]
clutter-actor-meta: Fix _clutter_meta_group_has_metas_no_internal

This function was backwards i.e it is supposed to check for metas that
are *not* internal, hence the name.
Comment 2 drago01 2011-10-01 10:40:10 UTC
Created attachment 197955 [details] [review]
clutter-actor-meta: Fix _clutter_meta_group_has_metas_no_internal

This function is backwards i.e it is supposed to check for metas that
are *not* internal, hence the name.

--

s/was/is/ in commit message.
Comment 3 Emmanuele Bassi (:ebassi) 2011-10-01 11:09:47 UTC
Review of attachment 197955 [details] [review]:

whoopsie, I should have caught this in review.
Comment 4 drago01 2011-10-01 11:10:39 UTC
Attachment 197955 [details] pushed as d331e92 - clutter-actor-meta: Fix _clutter_meta_group_has_metas_no_internal