After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 660429 - Stop using GtkTable
Stop using GtkTable
Status: RESOLVED FIXED
Product: empathy
Classification: Core
Component: General
2.33.x
Other Linux
: Normal normal
: ---
Assigned To: empathy-maint
empathy-maint
Depends on:
Blocks:
 
 
Reported: 2011-09-29 08:40 UTC by Guillaume Desmottes
Modified: 2011-09-29 12:46 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
empathy-new-chatroom-dialog.ui: load/save in Glade (13.65 KB, patch)
2011-09-29 12:12 UTC, Guillaume Desmottes 		committed Details | Review
new-chatroom-dialog: use GtkGrid instead of GtkTable (6.60 KB, patch)
2011-09-29 12:12 UTC, Guillaume Desmottes 		committed Details | Review
empathy-contact-selector-dialog.ui: load/save in Glade (1.81 KB, patch)
2011-09-29 12:12 UTC, Guillaume Desmottes 		committed Details | Review
contact-selector-dialog: use GtkGrid instead of GtkTable (4.67 KB, patch)
2011-09-29 12:13 UTC, Guillaume Desmottes 		committed Details | Review
streamed-media-window: use GtkGrid instead of GtkTable (9.46 KB, patch)
2011-09-29 12:13 UTC, Guillaume Desmottes 		committed Details | Review
call-window: use GtkGrid instead of GtkTable (9.41 KB, patch)
2011-09-29 12:13 UTC, Guillaume Desmottes 		committed Details | Review
individual-widget: use GtkGrid instead of GtkTable (4.28 KB, patch)
2011-09-29 12:13 UTC, Guillaume Desmottes 		committed Details | Review

Description Guillaume Desmottes 2011-09-29 08:40:36 UTC 
GtkTable is now deprecated, it would be cool to stop using in 3.4
http://mail.gnome.org/archives/desktop-devel-list/2011-September/msg00184.html

This bug is mostly a meta bug so feel free to open separated bugs for specific part of the port.
Comment 1 Guillaume Desmottes 2011-09-29 12:12:27 UTC 
Created attachment 197749 [details] [review]
empathy-new-chatroom-dialog.ui: load/save in Glade

No change.
Comment 2 Guillaume Desmottes 2011-09-29 12:12:39 UTC 
Created attachment 197750 [details] [review]
new-chatroom-dialog: use GtkGrid instead of GtkTable
Comment 3 Guillaume Desmottes 2011-09-29 12:12:51 UTC 
Created attachment 197751 [details] [review]
empathy-contact-selector-dialog.ui: load/save in Glade

No change.
Comment 4 Guillaume Desmottes 2011-09-29 12:13:03 UTC 
Created attachment 197752 [details] [review]
contact-selector-dialog: use GtkGrid instead of GtkTable
Comment 5 Guillaume Desmottes 2011-09-29 12:13:05 UTC 
Created attachment 197753 [details] [review]
streamed-media-window: use GtkGrid instead of GtkTable
Comment 6 Guillaume Desmottes 2011-09-29 12:13:08 UTC 
Created attachment 197754 [details] [review]
call-window: use GtkGrid instead of GtkTable
Comment 7 Guillaume Desmottes 2011-09-29 12:13:12 UTC 
Created attachment 197755 [details] [review]
individual-widget: use GtkGrid instead of GtkTable
Comment 8 Guillaume Desmottes 2011-09-29 12:13:46 UTC 
With those patches, empathy-account-widget-* are the last ones needing to be ported.
Comment 9 Xavier Claessens 2011-09-29 12:20:55 UTC 
Review of attachment 197750 [details] [review]:

::: src/empathy-new-chatroom-dialog.ui
@@ +170,3 @@
+                <child>
+                  <placeholder/>
+                </child>

all those placeholders are useless as far as I can tell
Comment 10 Xavier Claessens 2011-09-29 12:22:59 UTC 
The rest looks good
Comment 11 Guillaume Desmottes 2011-09-29 12:45:01 UTC 
Attachment 197749 [details] pushed as c4d480f - empathy-new-chatroom-dialog.ui: load/save in Glade
Attachment 197750 [details] pushed as 724817f - new-chatroom-dialog: use GtkGrid instead of GtkTable
Attachment 197751 [details] pushed as fe0e367 - empathy-contact-selector-dialog.ui: load/save in Glade
Attachment 197752 [details] pushed as c6bf0e6 - contact-selector-dialog: use GtkGrid instead of GtkTable
Attachment 197753 [details] pushed as 5647bac - streamed-media-window: use GtkGrid instead of GtkTable
Attachment 197754 [details] pushed as cd9637c - call-window: use GtkGrid instead of GtkTable
Attachment 197755 [details] pushed as 05e20d8 - individual-widget: use GtkGrid instead of GtkTable