After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 660084 - SIP calls are automatically answered
SIP calls are automatically answered
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: telepathy
3.1.x
Other Linux
: Normal critical
: ---
Assigned To: GNOME Shell Telepathy maintainer(s)
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2011-09-25 21:40 UTC by Cosimo Cecchi
Modified: 2011-09-26 12:50 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
telepathyClient: call delay on context when approving a FT or call (1.51 KB, patch)
2011-09-26 08:52 UTC, Guillaume Desmottes
committed Details | Review

Description Cosimo Cecchi 2011-09-25 21:40:59 UTC
When I receive a SIP call, it's automatically answered, i.e. the empathy call window directly pops up with the call already started after the first ring.
I believe this started recently...maybe gnome-shell interacting with the call approver in a wrong way?

telepathy-sofiasip-0.7.1
telepathy-glib-0.15.5
telepathy-mission-control-5.9.2
Comment 1 Guillaume Desmottes 2011-09-26 08:22:00 UTC
I just tried using the same versions and didn't manage to reproduce: gnome-shell proposes me to accept/decline the call and accepting it works fine.

Could you please attach mission-control logs and ideally dbus-monitor ones as well?
Comment 2 Guillaume Desmottes 2011-09-26 08:24:08 UTC
Which version of the Shell are you using btw?
Comment 3 Guillaume Desmottes 2011-09-26 08:35:12 UTC
Just got it! It seems to only happen when Empathy (the contact list) is not running.
Comment 4 Guillaume Desmottes 2011-09-26 08:50:31 UTC
That's a (stupid) gnome-shell bug; patch coming.
Comment 5 Guillaume Desmottes 2011-09-26 08:52:25 UTC
Created attachment 197453 [details] [review]
telepathyClient: call delay on context when approving a FT or call

Not doing so is considered as a bug as we don't accept the context right away.
It leads to tp-glib returning directly from the AddDispatchOperation() D-Bus
call and so automatically approve the channel if the Shell is the only
approver running.
Comment 6 Xavier Claessens 2011-09-26 09:00:14 UTC
Looks good, please merge asap. Should be blocker for 3.2.0 IMO.
Comment 7 Guillaume Desmottes 2011-09-26 09:01:55 UTC
(In reply to comment #6)
> Looks good, please merge asap. Should be blocker for 3.2.0 IMO.

Yeah it should. Auto accepting call, especially video calls, is a pretty nasty privacy violation.
Comment 8 Guillaume Desmottes 2011-09-26 12:50:07 UTC
Approved by the RT; merged to master.

Attachment 197453 [details] pushed as 00384cc - telepathyClient: call delay on context when approving a FT or call