After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 659867 - don't try to replace an existing keyboard
don't try to replace an existing keyboard
Status: RESOLVED FIXED
Product: caribou
Classification: Applications
Component: default
git master
Other Linux
: Normal normal
: ---
Assigned To: caribou-maint
caribou-maint
Depends on:
Blocks:
 
 
Reported: 2011-09-22 19:58 UTC by Dan Winship
Modified: 2011-09-23 11:53 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
keyboard-service: don't try to replace an existing keyboard (1.01 KB, patch)
2011-09-22 19:58 UTC, Dan Winship 		committed Details | Review

Description Dan Winship 2011-09-22 19:58:47 UTC 
Created attachment 197288 [details] [review]
keyboard-service: don't try to replace an existing keyboard

Under certain circumstances (especially if gnome-shell crashes and is restarted), antler can end up running while gnome-shell is running. In order to make sure that gnome-shell can always reassert its keyboard over antler, this patch to remove the REPLACE flag from antler's D-Bus name registration is useful. (Since antler already specifies ALLOW_REPLACEMENT, gnome-shell could steal control of the keyboard back from it... but you want to ensure that they aren't going to keep fighting back and forth.)

There shouldn't be any bad side effects of this; if gnome-shell isn't running, then the REPLACE flag is just a no-op anyway. (I guess it means that if you want to start a new antler, you have to kill the old one first, rather than just starting a new one and having it kill the old one for you...)
Comment 1 Matthias Clasen 2011-09-22 20:47:18 UTC 
Works fine in my testing, together with the corresponding shell patch, and prevents antler from coming up.
Comment 2 Eitan Isaacson 2011-09-22 20:47:58 UTC 
Excellent. Please commit.
Comment 3 Dan Winship 2011-09-23 11:53:28 UTC 
Attachment 197288 [details] pushed as 16e69bf - keyboard-service: don't try to replace an existing keyboard