GNOME Bugzilla – Bug 659862
alien box pointer when tray icon summary notification is clicked
Last modified: 2011-09-26 23:37:30 UTC
An alien box pointer is left behind when a summary notification associated with a tray icon is clicked, as shown in this screenshot: http://mclasen.fedorapeople.org/gray-alien.png This can be reproduced by getting any tray icon that has a notification, such as: 1) adding an Evolution calendar event and setting up an alarm for it (you can make it notify you at any arbitrary time before the event, such as 1 minute, and then move the event to reproduce the bug again) 2) enabling the system tray icon in the XChat preferences and getting a message that produces a notification this._summaryBoxPointer.actor.hide() does get called in _hideSummayBoxPointer(), but it doesn't seem to have an effect. Also, if Main.messageTray._summaryBoxPointer.actor.hide() is called in the LookingGlass, it hides the rectangle temporarily, but then it appears again when the message tray is shown.
Created attachment 197311 [details] [review] messageTray: unset this._clickedSummaryItem if we are hiding the summary box pointer and don't have a new clicked summary item This ensures that this._clickedSummaryItem is always unset correctly. Because we disconnect the signals that have _adjustSummaryBoxPointerPosition() as a callback when unsetting this._clickedSummaryItem, we no longer call setPosition() on this._summaryBoxPointer after it is hidden. Calling setPosition() shows the box pointer again, which previously resulted in an empty box pointer staying behind when a notification associated with a tray icon was clicked. It's possible that it would be ok to remove this._summaryState != State.SHOWN from the if statement, but it seems safer to leave it in for now. I will be away till Monday, so, if the patch looks good, it'd be great if the person who reviews it asks for a freeze break for this and commits it.
Comment on attachment 197311 [details] [review] messageTray: unset this._clickedSummaryItem if we are hiding the summary box pointer and don't have a new clicked summary item makes sense
Thanks! Filed a freeze break request: https://mail.gnome.org/archives/release-team/2011-September/msg00308.html