After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 659826 - new broadband connection weirdness in first page of the assistant
new broadband connection weirdness in first page of the assistant
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: Widget: Other
3.1.x
Other All
: Normal normal
: ---
Assigned To: gtk-bugs
gtk-bugs
Depends on:
Blocks:
 
 
Reported: 2011-09-22 13:35 UTC by Baptiste Mille-Mathias
Modified: 2011-09-23 11:45 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
screenshot. (29.34 KB, image/png)
2011-09-22 13:35 UTC, Baptiste Mille-Mathias 		  Details
GtkAssistant: Fix problems with gtk_widget_show_all() (1.08 KB, patch)
2011-09-22 18:48 UTC, Bastien Nocera 		none Details | Review
GtkAssistant: Fix problems with gtk_widget_show_all() (1.77 KB, patch)
2011-09-22 21:01 UTC, Bastien Nocera 		committed Details | Review

Description Baptiste Mille-Mathias 2011-09-22 13:35:06 UTC 
In fedora 16, I crated a bluetooth connection to my phone, and launch the dund plugin, which launched this assistant, and here come the first dialog:
* duplicate items (on the left)
* non-sense in the buttons.

If I press the "continue" button, it works fine, no more duplicated entrie or buttons weirdness.

NetworkManager version: 0.9.0.2.fc16
Comment 1 Baptiste Mille-Mathias 2011-09-22 13:35:32 UTC 
Created attachment 197245 [details]
screenshot.
Comment 2 Dan Williams 2011-09-22 18:36:19 UTC 
Note that it shouldn't be required to launch dund at all, since NetworkManager will handle all that for you.  When you're doing pairing with the phone, you'll get a dialog that has a checkbox for "Use this phone to connect to the Internet" which should launch the wizard for you and do the right thing.  Looking into the wizard oddness though.
Comment 3 Dan Williams 2011-09-22 18:46:22 UTC 
This is apparently a GTK bug, mclasen says:

(01:37:31 PM) mclasen: looks like you are callling show_all, and we don't deal with it ?
Comment 4 Bastien Nocera 2011-09-22 18:48:11 UTC 
Created attachment 197279 [details] [review]
GtkAssistant: Fix problems with gtk_widget_show_all()

gtk_widget_show_all() would have shown every single item inside
the GtkAssistant sidebar.
Comment 5 Bastien Nocera 2011-09-22 21:01:52 UTC 
Created attachment 197293 [details] [review]
GtkAssistant: Fix problems with gtk_widget_show_all()

gtk_widget_show_all() would have shown every single item inside
the GtkAssistant sidebar, as well as all the navigation buttons.
Comment 6 Bastien Nocera 2011-09-22 21:02:43 UTC 
Comment on attachment 197279 [details] [review]
GtkAssistant: Fix problems with gtk_widget_show_all()

And there's also the case of the navigation buttons. Tested, works for me.
Comment 7 Matthias Clasen 2011-09-22 22:23:49 UTC 
Review of attachment 197293 [details] [review]:

Thanks, please commit
Comment 8 Bastien Nocera 2011-09-23 11:45:29 UTC 
Pushed to master.

Attachment 197293 [details] pushed as a0fc947 - GtkAssistant: Fix problems with gtk_widget_show_all()