After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 659441 - Uninitialized variable used
Uninitialized variable used
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: Widget: GtkTreeView
unspecified
Other Linux
: Normal normal
: ---
Assigned To: gtktreeview-bugs
gtktreeview-bugs
: 659733 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2011-09-19 09:16 UTC by Xavier Claessens
Modified: 2011-09-21 18:54 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
GtkTreeModelFilter: Fix build warnings (1.72 KB, patch)
2011-09-19 09:20 UTC, Xavier Claessens 		accepted-commit_now Details | Review

Description Xavier Claessens 2011-09-19 09:16:08 UTC 
Get that warning when building GTK:

gtktreemodelfilter.c:1658:7: warning: 'parent' is used uninitialized in this function [-Wuninitialized]

And indeed parent is used before assigning a value in gtk_tree_model_filter_remove_elt_from_level().

From a quick look, it should have no influence, but still worth a fix.
Comment 1 Xavier Claessens 2011-09-19 09:20:47 UTC 
Created attachment 196906 [details] [review]
GtkTreeModelFilter: Fix build warnings
Comment 2 Kristian Rietveld 2011-09-20 05:51:06 UTC 
Comment on attachment 196906 [details] [review]
GtkTreeModelFilter: Fix build warnings

Looks good.

(I wonder why my clang didn't catch this, smells like a compiler bug ;)
Comment 3 Xavier Claessens 2011-09-20 07:08:03 UTC 
Thanks, merged.
Comment 4 Frederic Peters 2011-09-21 18:54:50 UTC 
*** Bug 659733 has been marked as a duplicate of this bug. ***