After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 659237 - [gstrtpbin] clock is not unreffed after finish using it
[gstrtpbin] clock is not unreffed after finish using it
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-good
git master
Other Linux
: Normal normal
: 0.10.31
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2011-09-16 12:41 UTC by Ha Nguyen
Modified: 2011-09-19 12:06 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
add missing gst_object_unref for clock (552 bytes, patch)
2011-09-16 12:44 UTC, Ha Nguyen 		none Details | Review
recreated the patch using git format-patch -n1 (890 bytes, patch)
2011-09-19 10:18 UTC, Ha Nguyen 		committed Details | Review

Description Ha Nguyen 2011-09-16 12:41:31 UTC 
A clock is obtained for each buffering change in GST_MESSAGE_BUFFERING handler but not unreffed after finish using it, causing it never get disposed and finalized.
Comment 1 Ha Nguyen 2011-09-16 12:44:44 UTC 
Created attachment 196715 [details] [review]
add missing gst_object_unref for clock
Comment 2 David Schleef 2011-09-17 20:06:34 UTC 
Could you recreate this patch using 'git format-patch'?  This retains author information and makes it easier to review.
Comment 3 Ha Nguyen 2011-09-19 10:18:55 UTC 
Created attachment 196917 [details] [review]
recreated the patch using git format-patch -n1
Comment 4 Sebastian Dröge (slomo) 2011-09-19 12:06:19 UTC 
commit 931020158e7d727d00dc8dd260d1a956f80d2126
Author: Ha Nguyen <hanguytv@gmail.com>
Date:   Mon Sep 19 12:15:11 2011 +0200

    rtpbin: Fix a leaked clock for each buffering message
    
    Fixes bug #659237.