After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 659210 - dash: Adjust placeholder size to icon size
dash: Adjust placeholder size to icon size
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2011-09-16 02:41 UTC by Rui Matos
Modified: 2011-09-20 20:05 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
dash: Adjust placeholder size to icon size (1.36 KB, patch)
2011-09-16 02:41 UTC, Rui Matos 		committed Details | Review

Description Rui Matos 2011-09-16 02:41:04 UTC 
See attached patch.
Comment 1 Rui Matos 2011-09-16 02:41:06 UTC 
Created attachment 196686 [details] [review]
dash: Adjust placeholder size to icon size

The placeholder looked odd near small icons and would cause the dash to get
wider when visible and narrower when hidden.
Comment 2 Florian Müllner 2011-09-20 19:47:52 UTC 
Review of attachment 196686 [details] [review]:

Looks good.

(I'd use present tense in the commit message, as it's the current state: ... looks odd ... causes)
Comment 3 Rui Matos 2011-09-20 20:05:55 UTC 
Attachment 196686 [details] pushed as 3f61f39 - dash: Adjust placeholder size to icon
size

(In reply to comment #2)
> (I'd use present tense in the commit message, as it's the current state: ...
> looks odd ... causes)

Ok, changed the commit message accordingly.