After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 659200 - [PATCH] Use correct duration on ClutterState transitions with wildcard source
[PATCH] Use correct duration on ClutterState transitions with wildcard source
Status: RESOLVED FIXED
Product: clutter
Classification: Platform
Component: general
git master
Other All
: Normal normal
: ---
Assigned To: clutter-maint
clutter-maint
Depends on:
Blocks:
 
 
Reported: 2011-09-16 00:49 UTC by Craig Hughes
Modified: 2011-09-19 17:36 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Patch to properly calculate duration for wildcard state transitions (1.49 KB, patch)
2011-09-16 00:49 UTC, Craig Hughes 		rejected Details | Review
Replacement patch which actually works this time. (1.26 KB, patch)
2011-09-19 16:31 UTC, Craig Hughes 		committed Details | Review

Description Craig Hughes 2011-09-16 00:49:03 UTC 
Created attachment 196685 [details] [review]
Patch to properly calculate duration for wildcard state transitions

There's a bug in ClutterState where using a wildcard source for a transition and specifying a duration for that transition will not work.  The wildcard source duration is not considered when looking up the duration during a state change.  The attached patch resolves this defect.
Comment 1 Emmanuele Bassi (:ebassi) 2011-09-16 08:27:19 UTC 
Review of attachment 196685 [details] [review]:

looks okay to me.
Comment 2 Emmanuele Bassi (:ebassi) 2011-09-19 10:51:05 UTC 
Review of attachment 196685 [details] [review]:

actually, no: I was on crack. the patch is wrong, and it doesn't even compile. are you sure you attached the right one?
Comment 3 Craig Hughes 2011-09-19 16:24:24 UTC 
Hmm.  Must be some good crack that crept into my office too.  That "start" should be "state".  Not sure how it compiled for me unless I did something crazy like fix->gen patch->compile->fix->compile->test and sent you the bad patch...  I'll regenerate it.
Comment 4 Craig Hughes 2011-09-19 16:31:27 UTC 
Created attachment 196964 [details] [review]
Replacement patch which actually works this time.

Replacement patch which spells "state" correctly.
Comment 5 Emmanuele Bassi (:ebassi) 2011-09-19 17:29:23 UTC 
Review of attachment 196964 [details] [review]:

looks good, now.
Comment 6 Emmanuele Bassi (:ebassi) 2011-09-19 17:36:29 UTC 
thanks, attachment 196964 [details] [review] pushed to master, it'll be in 1.8.0.