After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 659139 - gstpad: make some debug traces more useful
gstpad: make some debug traces more useful
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gstreamer (core)
unspecified
Other All
: Normal trivial
: 0.10.36
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2011-09-15 12:22 UTC by Vincent Penquerc'h
Modified: 2011-09-16 11:12 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
gstpad: make some debug traces more useful (1.53 KB, patch)
2011-09-15 12:22 UTC, Vincent Penquerc'h 		needs-work Details | Review
gstpad: make some debug traces more useful (1.54 KB, patch)
2011-09-15 16:38 UTC, Vincent Penquerc'h 		committed Details | Review

Description Vincent Penquerc'h 2011-09-15 12:22:02 UTC 
gstpad: make some debug traces more useful
Comment 1 Vincent Penquerc'h 2011-09-15 12:22:04 UTC 
Created attachment 196612 [details] [review]
gstpad: make some debug traces more useful
Comment 2 Olivier Crête 2011-09-15 16:19:22 UTC 
What is GST_BUFFER_CAPS() is NULL ?
Comment 3 Vincent Penquerc'h 2011-09-15 16:32:50 UTC 
You can have buffers with NULL caps (without being a bug elsewhere) ?
Comment 4 Vincent Penquerc'h 2011-09-15 16:38:32 UTC 
Created attachment 196654 [details] [review]
gstpad: make some debug traces more useful
Comment 5 Tim-Philipp Müller 2011-09-16 11:11:49 UTC 
> You can have buffers with NULL caps (without being a bug elsewhere) ?

Yes, that just means "same as previous buffer". The first buffer must have caps though (and really, all buffers *should* have caps, still..).

There's also the case of e.g. filesrc or souphttpsrc or so which don't put caps on buffers and leave downstream to typefind them.


I've changed it so that it just doesn't mention the type if the buffer has NULL caps, I don't think putting "[NULL caps]" in the log will add much information (but more noise, IMHO).


 commit 91c217c714ceb052cecdbab61f48a1e3fb9955f7
 Author: Vincent Penquerc'h <vincent.penquerch@collabora.co.uk>
 Date:   Thu Sep 15 13:20:15 2011 +0100

    pad: make some debug traces more useful
    
    https://bugzilla.gnome.org/show_bug.cgi?id=659139


PS: when you attach an updated patch, please make sure to check the right boxes for 'Obsoletes: [ ] previous patch'