After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 659064 - Folks introspection data doesn't reference non-devel libraries
Folks introspection data doesn't reference non-devel libraries
Status: RESOLVED DUPLICATE of bug 658002
Product: folks
Classification: Platform
Component: general
git master
Other Linux
: Normal normal
: Unset
Assigned To: folks-maint
folks-maint
: 658860 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2011-09-14 15:27 UTC by Cosimo Cecchi
Modified: 2011-09-14 16:50 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
build: don't make the typelib depend on devel shared object files (805 bytes, patch)
2011-09-14 15:31 UTC, Cosimo Cecchi
rejected Details | Review

Description Cosimo Cecchi 2011-09-14 15:27:26 UTC
See e.g. [1] and [2] for a very similar Tracker issue.

The problem here is the typelib references the .so file instead of .so.$LT_CURRENT, so when e.g. I run gnome-shell on a system without folks-devel installed (which provides libfolks.so), I get this error at startup;

"Log level 16: Failed to load shared library 'libfolks.so' referenced by the typelib: libfolks.so: cannot open shared object file: No such file or directory"

[ and then e.g. search in the shell throws funny exceptions because things are not being parsed correctly by the introspection system ]

[1] https://bugzilla.gnome.org/show_bug.cgi?id=658588
[2] http://git.gnome.org/browse/tracker/commit/src/libtracker-sparql/Makefile.am?id=7edc4acc7e33f369616430edb63b0f060b9c3ecd
Comment 1 Cosimo Cecchi 2011-09-14 15:31:18 UTC
Created attachment 196512 [details] [review]
build: don't make the typelib depend on devel shared object files

Untested patch, but builds fine.
Comment 2 Cosimo Cecchi 2011-09-14 15:32:45 UTC
*** Bug 658860 has been marked as a duplicate of this bug. ***
Comment 3 Philip Withnall 2011-09-14 16:21:19 UTC
Duplicate of bug #658002, which also has a patch. I think Raúl's is probably more correct, because libfolks.so.$(LT_CURRENT) is a symlink for me, linked to libfolks.so.foo.bar.baz. However, my libtools knowledge is weak, so I'll ask around for an opinion on both approaches.

*** This bug has been marked as a duplicate of bug 658002 ***
Comment 4 Philip Withnall 2011-09-14 16:33:12 UTC
Review of attachment 196512 [details] [review]:

After talking to ebassi on IRC, he's confirmed that your approach is the right one, and that I don't know what I'm talking about. Please commit to master. :-)
Comment 5 Philip Withnall 2011-09-14 16:50:53 UTC
Review of attachment 196512 [details] [review]:

Sorry, I was wrong. libtool doesn't just append LT_CURRENT to the library name; it does some calculations involving LT_AGE as well.

Comment added to bug #658002 about this.