After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 659009 - [matroskademux] property for configuring gap handling
[matroskademux] property for configuring gap handling
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-good
git master
Other Linux
: Normal enhancement
: 0.10.31
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2011-09-14 05:23 UTC by David Svensson Fors
Modified: 2011-09-14 13:01 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Property for configuring max gap time (4.90 KB, patch)
2011-09-14 05:23 UTC, David Svensson Fors
committed Details | Review

Description David Svensson Fors 2011-09-14 05:23:53 UTC
Created attachment 196466 [details] [review]
Property for configuring max gap time

The attached proposed patch adds a property "max-gap-time" to the Matroska demuxer. The property is used for configuring how long a gap between timestamps can be, before the demuxer skips the gap by sending out newsegment events. Default is 2 seconds, like without the patch. GST_CLOCK_TIME_NONE can be used for not skipping gaps at all.

Having the max gap time configurable is useful, because in some use cases you'd want to present gaps in recorded media, also for gaps longer than 2 seconds. In our case we record to SD cards, and sometimes the recording process gets stuck for a few seconds. Then, we want this to show when we play the media.
Comment 1 Mark Nauwelaerts 2011-09-14 13:01:04 UTC
Thanks.  Committed with minor change (use 0 rather than _NONE to disable).

commit 682ae32f6f8a81e4c3cb164bb285c3d5f1069fa5
Author: David Svensson Fors <davidsf@axis.com>
Date:   Wed Sep 14 14:46:00 2011 +0200

    matroskademux: configurable timestamp gap handling
    
    matroskademux performs segment tricks to skip gaps in streams,
    notably at start for non 0 based files.  There may however be
    cases when full presentation (including intermediate gaps) is
    desired, so a property allows to configure as of which gap
    to act (or not at all).
    
    API: GstMatroskaDemux::max-gap-time
    
    Fixes #659009.