After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 658964 - Toolbar and treeview don't join properly
Toolbar and treeview don't join properly
Status: RESOLVED FIXED
Product: gnome-control-center
Classification: Core
Component: Online Accounts
git master
Other Linux
: Normal normal
: ---
Assigned To: Cosimo Cecchi
Control-Center Maintainers
Depends on:
Blocks:
 
 
Reported: 2011-09-13 16:11 UTC by Bastien Nocera
Modified: 2011-09-14 17:37 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
online-accounts: don't use a GtkTable to arrange widgets (8.34 KB, patch)
2011-09-14 16:07 UTC, Cosimo Cecchi 		needs-work Details | Review

Description Bastien Nocera 2011-09-13 16:11:11 UTC 
The lower part of the treeview doesn't seem to get rounded as it should. The code looks the same as the one used in the background panel, so I'm at loss why it would behave that way.
Comment 1 Matthias Clasen 2011-09-14 04:12:52 UTC 
Hmm, I can't figure this out either. Time to cc Cosimo
Comment 2 Bastien Nocera 2011-09-14 09:42:55 UTC 
(In reply to comment #1)
> Hmm, I can't figure this out either. Time to cc Cosimo

He was already assigned to it :)
Comment 3 Cosimo Cecchi 2011-09-14 16:07:52 UTC 
Created attachment 196521 [details] [review]
online-accounts: don't use a GtkTable to arrange widgets

Use simple GtkBox widgets instead, which allow the theme to style the
rounded corners for inline toolbar under the treeview properly
Comment 4 Bastien Nocera 2011-09-14 16:29:47 UTC 
Review of attachment 196521 [details] [review]:

<hadess> cosimoc, right, why does the table not work then? :)
<cosimoc> hadess, because the way we set rounded corners in the theme is by matching for nth-child(last) inline toolbars
 hadess, and GtkTable doesn't support that
<hadess> cosimoc, ok, would be great if you could put that information in the commit message then

Note that, without any accounts selected, or configured, the "Select an account" label is not centred anymore.
Comment 5 Cosimo Cecchi 2011-09-14 17:37:43 UTC 
Attachment 196521 [details] pushed as 2621a96 - online-accounts: don't use a GtkTable to arrange widgets

Okay. I tweaked the commit message, fixed the centered label bug for no accounts (it was just missing an expand=true flag in the GtkBox packing) and pushed this to master.