GNOME Bugzilla – Bug 658908
Provide a more useful message when accounts crash than “No reason specified”
Last modified: 2012-09-13 09:34:46 UTC
As mentioned on <https://bugs.freedesktop.org/show_bug.cgi?id=40129>, Empathy currently shows “No reason specified” in the error bar when a CM falls over. MC does actually provide enough information for Empathy to know the CM crashed (or something else has gone wrong with the CM). We can thus make Empathy show something like “Internal error” in this case.
Created attachment 196358 [details] [review] Utils: provide a human-readable message for CM crashes
Created attachment 196359 [details] [review] telepathyClient: show CM crashes as “Internal error” I can't find any way to get access to a string constant version of this standard(ish) D-Bus error name.
(In reply to comment #2) > Created an attachment (id=196359) [details] [review] > telepathyClient: show CM crashes as “Internal error” I haven't tested this patch, I must confess. :) There might be some more useful message we could show than “Internal error”—I can't think of any other “something crashed” messages to crib wording from.
Review of attachment 196358 [details] [review]: Looks good, but as it's not really helpful to users any way, I don't think it's worth asking a string exception. We'll merge once we have branched.
Oh, we should probably add this string in the Shell as well.
(In reply to comment #4) > Looks good, but as it's not really helpful to users any way, I don't think it's > worth asking a string exception. We'll merge once we have branched. ping?
Comment on attachment 196358 [details] [review] Utils: provide a human-readable message for CM crashes Rebased and committed.
Review of attachment 196359 [details] [review]: The subject needs to be fixed up to not have the encoding and it's better to spell out Connection Manager. So "telepathyClient: show Connection Manager crashes as Internal error" The commit message body should explain why the change is made, not explain the code choices in the patch. So perhaps "We use same error messages as Empathy, and this one was added in commit 756dbf5a7a658ba472fc63ef6034d2c4d90e3260 ." and the bug link https://bugzilla.gnome.org/show_bug.cgi?id=658908 on the new line. From looking at http://developer.gnome.org/gio/stable/gio-GDBusError.html and glib/gio/gdbuserror.c , it doesn't look like GDBusError provides any way to retrieve error names. Gio.DBusError.NO_REPLY gives the error code, but there is no way to convert it to the name or get any constant for the name. I guess it's ok, and it's fine to just use the full string here. I don't think it's necessary to add the comment in the code about it. It's ok to commit the patch with the suggested changes. ::: js/ui/telepathyClient.js @@ +1438,3 @@ _connectionErrorMessages[Tp.error_get_dbus_name(Tp.Error.CERT_LIMIT_EXCEEDED)] = _("The length of the server certificate, or the depth of the server certificate chain, exceed the limits imposed by the cryptography library"); +_connectionErrorMessages["org.freedesktop.DBus.Error.NoReply"] This should use single quotes because we use single quotes for strings that don't need to be translated.
Is it possible to provide a more descriptive error message in both places, such as "Failed to establish a connection" ?
Comment on attachment 196359 [details] [review] telepathyClient: show CM crashes as “Internal error” Committed a revised version of this patch as http://git.gnome.org/browse/gnome-shell/commit/?id=019dd2e1b073a368646bb89126e72ffbf4be6c1d .
Thanks for the review! (In reply to comment #9) > Is it possible to provide a more descriptive error message in both places, such > as "Failed to establish a connection" ? Is this really more descriptive than “Internal error”? The error condition is that a Telepathy component crashed; “Failed to establish a connection” sounds more like a connectivity issue. (I'm not married to “Internal error”, don't get me wrong, but I don't trust myself to come up with a more informative and non-scary way to describe “the CM crashed”.)
Patches have been merged, closing the bug.