After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 658857 - individual-widget: use GtkGrid instead of GtkTable internally
individual-widget: use GtkGrid instead of GtkTable internally
Status: RESOLVED FIXED
Product: empathy
Classification: Core
Component: General
unspecified
Other All
: Normal normal
: ---
Assigned To: empathy-maint
empathy-maint
Depends on:
Blocks:
 
 
Reported: 2011-09-12 21:00 UTC by Cosimo Cecchi
Modified: 2011-09-13 14:03 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
individual-widget: use GtkGrid instead of GtkTable internally (23.19 KB, patch)
2011-09-12 21:00 UTC, Cosimo Cecchi 		committed Details | Review

Description Cosimo Cecchi 2011-09-12 21:00:00 UTC 
https://bugzilla.gnome.org/show_bug.cgi?id=657621 has more details about what I'm trying to fix.
Comment 1 Cosimo Cecchi 2011-09-12 21:00:02 UTC 
Created attachment 196304 [details] [review]
individual-widget: use GtkGrid instead of GtkTable internally

EmpathyIndividualWidget (used both in the contact information dialogs
and in the tooltips) use a GtkTable internally to layout contact
details.

GtkTable is being deprecated, and does not correctly support
width-for-height size negotiation. So, there are cases where we get
funny overallocations bugs for wrapping GtkLabels; this is especially
annoying for tooltips, as they tend to grow huge vertically.

Porting the code to use a better container such as GtkGrid solves the
bug. This patch does not cover all the use of GtkTable in
EmpathyIndividualWidget, but enough to fix the tooltip sizing.
Comment 2 Guillaume Desmottes 2011-09-13 09:15:34 UTC 
Review of attachment 196304 [details] [review]:

Looks great, thanks for that patch!
Comment 3 Cosimo Cecchi 2011-09-13 14:03:30 UTC 
Attachment 196304 [details] pushed as 40bf91b - individual-widget: use GtkGrid instead of GtkTable internally

Thanks for the review, pushed to master.