After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 658675 - inconsistent time format
inconsistent time format
Status: RESOLVED WONTFIX
Product: gnome-shell
Classification: Core
Component: calendar
unspecified
Other Linux
: Normal normal
: ---
Assigned To: David Zeuthen (not reading bugmail)
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2011-09-09 20:09 UTC by Luc Pi
Modified: 2014-11-07 15:17 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Calendar: Remove leading zeros for 24h time format (924 bytes, patch)
2014-11-07 14:00 UTC, Bastien Nocera
committed Details | Review
Revert "Calendar: Remove leading zeros for 24h time format" (1.17 KB, patch)
2014-11-07 15:16 UTC, Florian Müllner
committed Details | Review

Description Luc Pi 2011-09-09 20:09:55 UTC
The time format is inconsistent regarding leading zeros

#. Translators: Shown in calendar event list, if 24h format
#: ../js/ui/calendar.js:68
msgctxt "event list time"
msgid "%H:%M"

#. Transators: Shown in calendar event list, if 12h format
#: ../js/ui/calendar.js:75
msgctxt "event list time"
msgid "%l:%M %p"


msgid "%H:%M"      has leading zeros
msgid "%l:%M %p"   has no leading zeros

==> suggesting:

msgid "%k:%M" for 24h (no leading zeros)
Comment 1 Fabio Durán Verdugo 2011-09-10 00:39:19 UTC
Thanks for the bug report. This particular bug has already been reported into our bug tracking system, but please feel free to report any further bugs you find.

*** This bug has been marked as a duplicate of bug 644390 ***
Comment 2 Luc Pi 2011-09-10 01:04:48 UTC
Fabio,
I cannot understand how this report is a duplicate from the other,
could you explain?
Comment 3 Luc Pi 2011-09-14 13:57:20 UTC
I reopen, in doubt
Comment 4 Bastien Nocera 2014-11-07 14:00:21 UTC
Created attachment 290165 [details] [review]
Calendar: Remove leading zeros for 24h time format
Comment 5 Carlos Soriano 2014-11-07 14:02:46 UTC
Review of attachment 290165 [details] [review]:

Nice
Comment 6 Bastien Nocera 2014-11-07 14:04:35 UTC
Attachment 290165 [details] pushed as 316f825 - Calendar: Remove leading zeros for 24h time format
Comment 7 Volker Sobek (weld) 2014-11-07 14:13:00 UTC
I don't think it is an inconsistency but rather a convention to use leading zeros in the 24h format and not in the 12h format.

http://en.wikipedia.org/wiki/24-hour_clock
Comment 8 Florian Müllner 2014-11-07 14:27:32 UTC
Mmmh, I kinda agree here - 12- and 24-hour clocks are already "inconsistent" past noon, so I don't see why this should not apply before noon as well; in fact, this difference allows to know which format is used at *any* time.
More importantly, this makes the 24-hour clock format used in calendar events inconsistent with the 24-hour clock format used in the wallclock (top bar), which is quite a bit worse. Either gnome-desktop needs to change as well, or this commit should be reverted.
Reopening for further discussion.
Comment 9 Carlos Soriano 2014-11-07 14:41:02 UTC
Right, seems there's a convention on that, and what fmuellner said.
Sorry to accept it that quick.
Comment 10 Jakub Steiner 2014-11-07 15:02:53 UTC
(In reply to comment #8)
> Mmmh, I kinda agree here - 12- and 24-hour clocks are already "inconsistent"


I agree. I'm by no means an expert, but it's very common to have the leading zero in the 24h format. convention trumps consistency here.
Comment 11 Florian Müllner 2014-11-07 15:16:18 UTC
Created attachment 290176 [details] [review]
Revert "Calendar: Remove leading zeros for 24h time format"

Leading zeros are common in the 24h format, and indeed used in the
wallclock in the top bar. Convention and consistency within the
same clock format trumps inconsistency between different time formats,
so reverting commit 316f825b2ac718.
Comment 12 Florian Müllner 2014-11-07 15:17:06 UTC
Attachment 290176 [details] pushed as 455595f - Revert "Calendar: Remove leading zeros for 24h time format"

Reverting as of comment #10