After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 658469 - Login dialog keeps growing when pressing up/down arrows
Login dialog keeps growing when pressing up/down arrows
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: login-screen
3.1.x
Other Linux
: Normal normal
: ---
Assigned To: Ray Strode [halfline]
gnome-shell-maint
: 659259 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2011-09-07 13:43 UTC by Vincent Untz
Modified: 2011-09-18 03:26 UTC
See Also:
GNOME target: 3.2
GNOME version: ---

Attachments
loginDialog: subtract padding when drawing focus line (1.37 KB, patch)
2011-09-17 22:47 UTC, Ray Strode [halfline] 		committed Details | Review

Description Vincent Untz 2011-09-07 13:43:46 UTC 
If I press up/down arrows to change the selected user, the login dialog keeps getting wider.
Comment 1 Matthias Clasen 2011-09-16 22:56:04 UTC 
*** Bug 659259 has been marked as a duplicate of this bug. ***
Comment 2 Ray Strode [halfline] 2011-09-17 22:44:34 UTC 
yay padding
Comment 3 Ray Strode [halfline] 2011-09-17 22:47:41 UTC 
Created attachment 196845 [details] [review]
loginDialog: subtract padding when drawing focus line

If there's no scrollbar in the user list it grows as the
user arrows around.  This is because it wasn't taking
padding into account when computing its destination size.
Comment 4 drago01 2011-09-18 00:05:00 UTC 
Review of attachment 196845 [details] [review]:

Makes sense just one minor nitpick, fine to commit with that fixed.

::: js/gdm/loginDialog.js
@@ +249,3 @@
 
+        let node = this.actor.get_theme_node();
+        let padding = node.get_padding(St.Side.LEFT) + node.get_padding(St.Side.RIGHT);

Should just use get_horizontal_padding().
Comment 5 Ray Strode [halfline] 2011-09-18 03:26:12 UTC 
pushed with suggested change

Attachment 196845 [details] pushed as 8466198 - loginDialog: subtract padding when drawing focus line