GNOME Bugzilla – Bug 658450
mpegvideoparse: make this build with older glib
Last modified: 2011-09-07 12:35:27 UTC
g_list_free_full is a new convenience function. Replace it with g_list_foreach and g_list_free.
Created attachment 195854 [details] [review] mpegvideoparse: make this build with older glib
Review of attachment 195854 [details] [review]: ::: gst/videoparsers/gstmpegvideoparse.c @@ +504,3 @@ } + g_list_foreach (mpvparse->typeoffsize, (GFunc) gst_mpegv_parse_free, NULL); Just pass g_free() here instead of a new function
g_free takes one argument, GDestroy two. While I think it actually would work given that the data pointer is the first argument, it may be confusing. If knowing this, you confirm you prefer passing g_free directly I'll change it.
Yes please pass g_free(), that's quite normal practice and is guaranteed to work because in C the caller is responsible for cleaning up the parameters after the call returned.
Created attachment 195864 [details] [review] mpegvideoparse: make this build with older glib g_list_free_full is a new convenience function. Replace it with g_list_foreach and g_list_free.
commit 1a6dbe1e273dff4e5a6e9e9c7936589ce62a7eca Author: Vincent Penquerc'h <vincent.penquerch@collabora.co.uk> Date: Wed Sep 7 12:32:48 2011 +0100 mpegvideoparse: make this build with older glib g_list_free_full is a new convenience function. Replace it with g_list_foreach and g_list_free. https://bugzilla.gnome.org/show_bug.cgi?id=658450