After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 658346 - Missing mnemonic for "Fetch list" button
Missing mnemonic for "Fetch list" button
Status: RESOLVED FIXED
Product: evolution-ews
Classification: Other
Component: Account Setup Plugin
unspecified
Other Linux
: Normal trivial
: ---
Assigned To: Evolution EWS maintainer(s)
Evolution EWS maintainer(s)
: 654546 657140 (view as bug list)
Depends on:
Blocks: 324810
 
 
Reported: 2011-09-06 10:56 UTC by André Klapper
Modified: 2011-09-20 10:56 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Evolution EWS patch (716 bytes, patch)
2011-09-13 12:26 UTC, Punit Jain 		none Details | Review
Evolution EWS patch (1.20 KB, patch)
2011-09-13 12:57 UTC, Punit Jain 		committed Details | Review

Description André Klapper 2011-09-06 10:56:27 UTC 
./src/account-setup-eplugin/exchange-ews-account-setup.c:		fetch_button = gtk_button_new_with_mnemonic (_("Fetch list"));

The string is missing a mnemonic. F should be fine.
Comment 1 Akhil Laddha 2011-09-06 11:51:03 UTC 
*** Bug 654546 has been marked as a duplicate of this bug. ***
Comment 2 Punit Jain 2011-09-13 12:26:35 UTC 
Created attachment 196360 [details] [review]
Evolution EWS patch
Comment 3 Punit Jain 2011-09-13 12:57:01 UTC 
Created attachment 196365 [details] [review]
Evolution EWS patch

Just realized we can't use 'F' key because it is already used for Forward. see bug 657140.
This patch solves bug 657140 too.
Using 'U' for Fetch URL and 'l' for Fetch list.
Comment 4 Chenthill P 2011-09-20 06:58:54 UTC 
Review of attachment 196365 [details] [review]:

looks good.
Comment 5 Punit Jain 2011-09-20 10:50:01 UTC 
Review of attachment 196365 [details] [review]:

Patch has been committed to master branch.
Thanks!
Comment 6 Akhil Laddha 2011-09-20 10:56:16 UTC 
*** Bug 657140 has been marked as a duplicate of this bug. ***