GNOME Bugzilla – Bug 658217
MetaWindowActor: clip shadow to a single monitor
Last modified: 2018-01-25 09:11:47 UTC
This is now split from bug 643075. I've changed the approach from computing the clip out of the ::paint handler and instead I'm now computing it whenever the window moves/resizes or there's a focus change. There might be more situations where we have to hook this though. Moving this out of ::paint had the nice side effect of no longer crashing on closing attached modal dialogs too.
Created attachment 195663 [details] [review] MetaWindowActor: clip shadow to a single monitor If a window isn't visible in more than one monitor we clip its shadow if it would "bleed" into an adjacent monitor.
Created attachment 195809 [details] [review] MetaWindowActor: clip shadow to a single monitor If a window isn't visible in more than one monitor we clip its shadow if it would "bleed" into an adjacent monitor. -- - added an early bail out when we don't have a shadow set yet which prevents a NULL pointer dereference in meta_window_actor_get_shadow_bounds()
*** Bug 660499 has been marked as a duplicate of this bug. ***
Ping? The amount of code here might seem like a lot but please bear in mind that for the single monitor case this should be quite cheap as we bail out early.
Created attachment 201558 [details] [review] MetaWindowActor: clip shadow to a single monitor -- Rebased on master.
Is this still necessary/wanted?
(In reply to comment #6) > Is this still necessary/wanted? I think so but let's try to get some design input. I've been running with this patch since I filed this bug so it does work and still applies.
I don't think we want this now that shadows are mostly client side, thus closing for now.