GNOME Bugzilla – Bug 658062
greeter should have a way to optionally add a logo
Last modified: 2011-09-19 04:36:46 UTC
The fallback greeter has a gconf key to optionally show a logo at the login screen: /apps/gdm/simple-greeter/logo_icon_name This lets administrators brand their labs, and lets downstream distributions sneak in a little branding as well. We should add something similiar to the new greeter (but using gsettings instead of gconf clearly)
This would be somewhat inconsistent with the lack of branding elsewhere in GNOME 3...
I think it would okay to do, though, anyway for 3 reasons: 1) When GDM dropped the themed greeter in 2.22 on, one of the user criticisms was that labs couldn't add their logo in. As a result of that feedback, Jon added a gconf key for it. 2) The Fedora design team and Fedora project leader really want to show the Fedora logo at the login screen 3) It would be off by default upstream, anyway.
Created attachment 195791 [details] [review] gdm: add optional logo to user list This commit adds the ability to set a small logo at the login screen for administrators and distributions.
Comment on attachment 195791 [details] [review] gdm: add optional logo to user list It seems wrong to have the preference for this be in gnome-shell. The fact that the login screen is implemented as a mode of gnome-shell is an implementation detail. So I feel like the pref should be in gdm. >+ let uri = file.get_uri(); >+ >+ if (uri) { pretty sure g_file_get_uri() can't fail
it's a greeter specific option though... I mean it's specific to this implementation of a greeter, not all greeter implementations. I don't really fancy the idea of having pieces of the greeter in the gdm tarball and pieces in the gnome-shell tarball.
Okay i've moved the settings to gdm, updated the patch to reflect your comments, and pushed it. Attachment 195791 [details] pushed as 391a220 - gdm: add optional logo to user list