After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 657949 - Update of gtk2 (2.24.5-3 -> 2.24.6-1) renders File >Save >"Choose Format" list unreadable
Update of gtk2 (2.24.5-3 -> 2.24.6-1) renders File >Save >"Choose Format" lis...
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: Widget: GtkFileChooser
2.24.x
Other Linux
: Normal major
: ---
Assigned To: gtk-bugs
Federico Mena Quintero
: 659047 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2011-09-01 15:46 UTC by David C. Rankin
Modified: 2011-09-27 11:48 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Screenshot showing unreadable "Choose Format" listbox (106.59 KB, image/jpeg)
2011-09-01 15:46 UTC, David C. Rankin 		  Details
gtk2-dont-ellipsize-filters.diff (925 bytes, patch)
2011-09-01 16:19 UTC, Federico Mena Quintero 		none Details | Review

Description David C. Rankin 2011-09-01 15:46:57 UTC 
Created attachment 195397 [details]
Screenshot showing unreadable "Choose Format" listbox

On upgrade of gtk2 (2.24.5-3 -> 2.24.6-1), the file >save >"Choose Format" list box become unreadable in LibreOffice and GIMP. This occurs in Libre where "Tools >Options >LibreOffice >General >Use LibreOffice dialogue boxes" is unchecked. This occurs in GIMP with its default settings.

Instead of the normal ~280 px width for the file >save >"Choose Format" list box which allow you to read the "All Formats", "ODT Text Document (.odt)", "OTT Document Template (.ott)", etc..., the list box is squished down to approximately 50 px wide making the list contents unreadable. (see attached screenshot newGTK-bug.jpg)

Downgrading from gtk2 (2.24.6-1 => 2.24.5-3) fixes the problem in both Libre and GIMP.
Comment 1 Federico Mena Quintero 2011-09-01 16:16:47 UTC 
I inadvertently merged the ellipsization code from 3.0 into 2.24.  While I can't replicate your bug, I'm pretty sure that this is the reason.

Can you please open gtk+/gtk/gtkfilechooserdefault.c, look for the filter_create() function, and remove the part that says

  g_object_set (G_OBJECT (cell),
		"ellipsize", PANGO_ELLIPSIZE_END,
		NULL);

If this fixes the problem, I'll commit that fix for the next 2.24.7 release.

Thanks!
Comment 2 Federico Mena Quintero 2011-09-01 16:19:23 UTC 
Created attachment 195400 [details] [review]
gtk2-dont-ellipsize-filters.diff

Here's a test patch for if you can build a package with it.
Comment 3 Ionut Biru 2011-09-01 16:34:55 UTC 
@Federico works fine with that patch. 

OFFTOPIC:

While you are at releasing a new version, can you also include bug 649979 ?
Comment 4 Federico Mena Quintero 2011-09-01 16:50:01 UTC 
(In reply to comment #3)
> @Federico works fine with that patch. 

Thanks!  Pushed to gtk-2-24.

> While you are at releasing a new version, can you also include bug 649979 ?

Done.
Comment 5 Federico Mena Quintero 2011-09-14 13:31:11 UTC 
*** Bug 659047 has been marked as a duplicate of this bug. ***
Comment 6 Pacho Ramos 2011-09-27 11:48:56 UTC 
Could you please release a new 2.24.7 version including this and all the fixes added since 2.24.6? Or, at least, could you let me know when a new tarball is expected to be released? 

Thanks a lot :-)