I went through all comments.
In fact alot of them are already solved.
Will attach a patch for the remaining ones in a moment. 

Just some small questions left.

(In reply to comment #0)
> #: ../daemon/gvfsafpconnection.c:1305 ../daemon/gvfsafpconnection.c:1332
> msgid "Got EOS"
> No idea what EOS is. Translator comment welcome.
Reading a bit in the source. I assume this is the "end of stream".

> #: ../daemon/gvfsafpserver.c:127
> msgid "Server doesn't support passwords longer than 256 characters"
> #: ../daemon/gvfsafpserver.c:414
> msgid "Server doesn't support passwords longer than 64 characters"
> If 256 and 64 were a %d this would be one string less to translate. :-P
Already fixed. A bit disccused in Bug #670162.

> #: ../daemon/gvfsafpserver.c:365 ../daemon/gvfsafpserver.c:585
> msgid "Login to AFP server %s failed"
> #: ../daemon/gvfsafpserver.c:669
> msgid "Login to AFP server %s failed (no suitable authentication mechanism
> found)"
> Second msgid could be split. Not that important though.
Already fixed.

> #: ../daemon/gvfsafpserver.c:865 ../daemon/gvfsbackendftp.c:518
> #: ../daemon/gvfsbackendsftp.c:985 ../daemon/gvfsbackendsmbbrowse.c:995
> #: ../daemon/gvfsbackendsmb.c:619
> msgid "Password dialog cancelled"
> I think AE mostly uses canceled spelling, while cancelled is BE.
This is used consistenly through gvfs with ll thus leaving it for now.

> #: ../daemon/gvfsbackendafc.c:928 ../daemon/gvfsbackendafpbrowse.c:257
> #: ../daemon/gvfsbackendafpbrowse.c:390 ../daemon/gvfsbackendafpbrowse.c:422
> #: ../daemon/gvfsbackendafp.c:467 ../daemon/gvfsbackendafp.c:780
> #: ../daemon/gvfsbackendafp.c:2869 ../daemon/gvfsbackendarchive.c:647
> #: ../daemon/gvfsbackendarchive.c:695 ../daemon/gvfsbackendarchive.c:747
> #: ../daemon/gvfsbackendarchive.c:776 ../daemon/gvfsbackendcdda.c:987
> #: ../daemon/gvfsbackendcomputer.c:627 ../daemon/gvfsbackenddnssd.c:398
> #: ../daemon/gvfsbackendftp.c:1067 ../daemon/gvfsbackendnetwork.c:602
> #: ../daemon/gvfsbackendsmbbrowse.c:1094 ../daemon/gvfsbackendsmbbrowse.c:1161
> #: ../daemon/gvfsbackendsmbbrowse.c:1333 ../daemon/gvfsbackendsmbbrowse.c:1403
> msgid "File doesn't exist"
> #: ../daemon/gvfsbackendafc.c:216 ../daemon/gvfsbackendftp.c:736
> msgid "File does not exist"
> Try to reuse existing strings.
fixed.

> #: ../daemon/gvfsbackendafp.c:1211 ../daemon/gvfsbackendburn.c:425
> #: ../daemon/gvfsbackenddav.c:2549 ../daemon/gvfsbackendsftp.c:1828
> msgid "Directory not empty"
> #: ../daemon/gvfsbackendafc.c:220
> msgid "The directory is not empty"
> Try to reuse existing strings.
fixed.

> #: ../daemon/gvfsbackendafc.c:493
> msgid "%s (jailbreak)"
> No idea how to translate that. What is %s here?
There is a translator comment there. However it is not picked up ... Could somebody have a look?

> #: ../daemon/gvfsbackendafp.c:1215
> msgid "Target object is marked as DeleteInhibit"
> #: ../daemon/gvfsbackendafp.c:1468
> msgid "Object being moved is marked as RenameInhibit"
> #: ../daemon/gvfsbackendafp.c:2222
> msgid "Target object is marked as RenameInhibit"
> No idea whether last word should be translated or not. Comment welcome.
All moved to daemon/gvfsafpvolume.c.

The inihibit term has been moved in brackets. 
e.g.  _("Target object is marked as not deletable (DeleteInhibit)"));

> #: ../daemon/gvfsbackendafp.c:2501
> msgid "File is not open for write access"
> #: ../daemon/gvfsbackendafp.c:2742
> msgid "File is not open for read access"
> I don't understand the "not open" in these sentences.
The error code AFP_RESULT_ACCESS_DENIED is in other places handled with a plain "Permission denied".

> #: ../daemon/gvfsbackendafp.c:2973
> msgid "Range lock conflict exists"
> What is a range lock?
Not sure. Maybe the AFP protocol allows to lock just a certain part of a file?
Help?

> #: ../daemon/gvfsbackendsftp.c:3350
> msgid "Unable to create temporary file"
> #: ../daemon/gvfsbackendafp.c:3212
> msgid "Couldn't create temporary file (%s)"
> Keeping the wording similar is welcome.
Already fixed.


> #: ../daemon/gvfsbackendsmb.c:788 ../daemon/gvfsbackendsmb.c:1284
> msgid "Unsupported seek type"
> #: ../daemon/gvfsbackendafc.c:1291
> msgid "Invalid seek type"
> Maybe these two strings could be merged?
As it is at the end of a case block. I guess "Invalid" is the same as "unsupported" here...

> #: ../daemon/gvfsbackendcomputer.c:941 ../daemon/gvfsbackendcomputer.c:1036
> #: ../daemon/gvfsbackendcomputer.c:1142 ../daemon/gvfsbackendcomputer.c:1232
> #: ../daemon/gvfsbackendcomputer.c:1305 ../daemon/gvfsbackendcomputer.c:1374
> msgid "Not a mountable file"
> #: ../daemon/gvfsbackendafpbrowse.c:285 ../daemon/gvfsbackendsmbbrowse.c:1089
> #: ../daemon/gvfsbackendsmbbrowse.c:1135
> msgid "The file is not a mountable"
> Merging these strings is welcome, if they express the same.
They are all in the try_mount_mountable function and thus mean the same IMO.
Fixed.

> #: ../daemon/gvfsbackendafp.c:1452
> msgid "Can't move directory into one of it's descendants"
> Typo: its
Already fixed.

> #: ../daemon/gvfsbackendafp.c:1585
> msgid "Couldn't open source file as Read/DenyWrite"
> No idea whether last word should be translated or not. Comment welcome.
Already fixed. (Gone).

> #: ../daemon/gvfsbackendafp.c:471 ../daemon/gvfsbackendafp.c:518
> #: ../daemon/gvfsbackendafp.c:2873 ../daemon/gvfsbackendafp.c:3276
> msgid "File is a directory"
> #: ../daemon/gvfsbackendafp.c:1912 ../daemon/gvfsbackendafp.c:2109
> #: ../daemon/gvfsbackenddav.c:2200 ../daemon/gvfsbackendftp.c:773
> #: ../daemon/gvfsbackendsftp.c:2333 ../daemon/gvfsbackendsftp.c:3069
> #: ../daemon/gvfsbackendsftp.c:3408 ../daemon/gvfsbackendsftp.c:4276
> msgid "File is directory"
> Please merge the two strings.
Already fixed.

> #: ../daemon/gvfsbackendafp.c:2354
> msgid "Volume is flat and doesn't support directories"
> I wouldn't know how to translate flat here.
I guess that means that directory creation is not supported because it is a flat volume (without hierachy). 

> #: ../daemon/gvfsbackendafp.c:4250
> msgid "AFP volume %s for %s on %s"
> #: ../daemon/gvfsbackendafp.c:4254
> msgid "AFP volume %s on %s"
> #: ../daemon/gvfsbackendafp.c:4272
> msgid "Couldn't mount AFP volume %s on %s"
> Translator comments explaining the %s'es welcome, as translation of "on" really
> depends on what the %s is.
Already fixed.

Created attachment 220059 [details] [review]
unifying translations

(In reply to comment #1)
> > #: ../daemon/gvfsbackendafc.c:493
> > msgid "%s (jailbreak)"
> > No idea how to translate that. What is %s here?
> There is a translator comment there. However it is not picked up ... Could
> somebody have a look?
Talked with André on IRC. This is solved with http://git.gnome.org/browse/gvfs/commit/?id=70e3a3e5bdf61cb7379c6e41cabbee26a4f12c57

Thanks.

William, could you have a look at this one as well? Thanks.

Felx, sure. Can you post a summary list of the issues as they stand now in one comment?

Hi William, thanks.
I went through all mentioned issues in the initial comment again.

> #: ../daemon/gvfsafpconnection.c:1305 ../daemon/gvfsafpconnection.c:1332
> msgid "Got EOS"
> No idea what EOS is. Translator comment welcome.
EOS was End of Stream in my opinion.
It reads now _("Connection unexpectedly went down"));.

> msgid "Server doesn't support passwords longer than 256 characters"
> msgid "Server doesn't support passwords longer than 64 characters"
Fixed in bug #670162.

> msgid "Login to AFP server %s failed"
> msgid "Login to AFP server %s failed (no suitable authentication mechanism
> found)"
> Second msgid could be split. Not that important though.
Reads
_("Unable to login to the server “%s” with the given password."),
_("Unable to connect to the server “%s”. No suitable authentication mechanism was found."),
Change connect to login?

> msgid "Password dialog cancelled"
> I think AE mostly uses canceled spelling, while cancelled is BE.
The message reads now _("The password prompt was cancelled.")
The AE, BE observation is correct.

> #: ../daemon/gvfsbackendafc.c:928 ../daemon/gvfsbackendafpbrowse.c:257
> #: ../daemon/gvfsbackendafpbrowse.c:390 ../daemon/gvfsbackendafpbrowse.c:422
> #: ../daemon/gvfsbackendafp.c:467 ../daemon/gvfsbackendafp.c:780
> #: ../daemon/gvfsbackendafp.c:2869 ../daemon/gvfsbackendarchive.c:647
> #: ../daemon/gvfsbackendarchive.c:695 ../daemon/gvfsbackendarchive.c:747
> #: ../daemon/gvfsbackendarchive.c:776 ../daemon/gvfsbackendcdda.c:987
> #: ../daemon/gvfsbackendcomputer.c:627 ../daemon/gvfsbackenddnssd.c:398
> #: ../daemon/gvfsbackendftp.c:1067 ../daemon/gvfsbackendnetwork.c:602
> #: ../daemon/gvfsbackendsmbbrowse.c:1094 ../daemon/gvfsbackendsmbbrowse.c:1161
> #: ../daemon/gvfsbackendsmbbrowse.c:1333 ../daemon/gvfsbackendsmbbrowse.c:1403
> msgid "File doesn't exist"
> #: ../daemon/gvfsbackendafc.c:216 ../daemon/gvfsbackendftp.c:736
> msgid "File does not exist"
> Try to reuse existing strings.
fixed.

> #: ../daemon/gvfsbackendafp.c:1211 ../daemon/gvfsbackendburn.c:425
> #: ../daemon/gvfsbackenddav.c:2549 ../daemon/gvfsbackendsftp.c:1828
> msgid "Directory not empty"
> #: ../daemon/gvfsbackendafc.c:220
> msgid "The directory is not empty"
> Try to reuse existing strings.
fixed.

> msgid "%s (jailbreak)"
> No idea how to translate that. What is %s here?
There is a translator comment now:
  /* translators:
   * This is the device name, with the service being browsed in brackets, eg.:
   * Alan Smithee's iPhone (jailbreak) */
However, to me it is unclear how jailbreak is the name of the service. Maybe jailbreaked fits better?

> msgid "Target object is marked as DeleteInhibit"
> msgid "Object being moved is marked as RenameInhibit"
> msgid "Target object is marked as RenameInhibit"
> No idea whether last word should be translated or not. Comment welcome.
All moved to daemon/gvfsafpvolume.c.

The inihibit term has been moved in brackets. 
e.g.  _("Target object is marked as not deletable (DeleteInhibit)"));

However, there is still no comment whether the should be translated.

> msgid "File is not open for write access"
> msgid "File is not open for read access"
> I don't understand the "not open" in these sentences.
Now at:
daemon/gvfsafpvolume.c:2643: _("File is not open for write access"));
daemon/gvfsafpvolume.c:2790: _("File is not open for read access"));
The error code AFP_RESULT_ACCESS_DENIED is in other places handled with a plain
"Permission denied".

> msgid "Range lock conflict exists"
> What is a range lock?
Not sure. Maybe the AFP protocol allows to lock just a certain part of a file?
Help?

> #: ../daemon/gvfsbackendsftp.c:3350
> msgid "Unable to create temporary file"
> #: ../daemon/gvfsbackendafp.c:3212
> msgid "Couldn't create temporary file (%s)"
> Keeping the wording similar is welcome.
fixed.

> #: ../daemon/gvfsbackendsmb.c:788 ../daemon/gvfsbackendsmb.c:1284
> msgid "Unsupported seek type"
> #: ../daemon/gvfsbackendafc.c:1291
> msgid "Invalid seek type"
> Maybe these two strings could be merged?
fixed.

> #: ../daemon/gvfsbackendcomputer.c:941 ../daemon/gvfsbackendcomputer.c:1036
> #: ../daemon/gvfsbackendcomputer.c:1142 ../daemon/gvfsbackendcomputer.c:1232
> #: ../daemon/gvfsbackendcomputer.c:1305 ../daemon/gvfsbackendcomputer.c:1374
> msgid "Not a mountable file"
> #: ../daemon/gvfsbackendafpbrowse.c:285 ../daemon/gvfsbackendsmbbrowse.c:1089
> #: ../daemon/gvfsbackendsmbbrowse.c:1135
> msgid "The file is not a mountable"
> Merging these strings is welcome, if they express the same.
fixed.

> #: ../daemon/gvfsbackendafp.c:1452
> msgid "Can't move directory into one of it's descendants"
> Typo: its
fixed.

> #: ../daemon/gvfsbackendafp.c:1585
> msgid "Couldn't open source file as Read/DenyWrite"
> No idea whether last word should be translated or not. Comment welcome.
Gone.

> #: ../daemon/gvfsbackendafp.c:471 ../daemon/gvfsbackendafp.c:518
> #: ../daemon/gvfsbackendafp.c:2873 ../daemon/gvfsbackendafp.c:3276
> msgid "File is a directory"
> #: ../daemon/gvfsbackendafp.c:1912 ../daemon/gvfsbackendafp.c:2109
> #: ../daemon/gvfsbackenddav.c:2200 ../daemon/gvfsbackendftp.c:773
> #: ../daemon/gvfsbackendsftp.c:2333 ../daemon/gvfsbackendsftp.c:3069
> #: ../daemon/gvfsbackendsftp.c:3408 ../daemon/gvfsbackendsftp.c:4276
> msgid "File is directory"
> Please merge the two strings.
fixed.

> #: ../daemon/gvfsbackendafp.c:2354
> msgid "Volume is flat and doesn't support directories"
> I wouldn't know how to translate flat here.
I guess that means that directory creation is not supported because it is a
flat volume (without hierachy).
Please add comment.

> #: ../daemon/gvfsbackendafp.c:4250
> msgid "AFP volume %s for %s on %s"
> #: ../daemon/gvfsbackendafp.c:4254
> msgid "AFP volume %s on %s"
> #: ../daemon/gvfsbackendafp.c:4272
> msgid "Couldn't mount AFP volume %s on %s"
> Translator comments explaining the %s'es welcome, as translation of "on" really
> depends on what the %s is.
fixed.

Anybody willing to review the comment above? Translations are open again.

Any chance to solve this?

Review of attachment 220059 [details] [review]:

Looks good, however it would be nice to fix "File does not exist" also in the gvfsbackendmtp.c to be fully consistent.

Comment on attachment 220059 [details] [review]
unifying translations

Pushed as commit f74ae0faf67b9338418fc7c3760ffac5e8df8d63 also with suggested changes in mtp backend.

Let this bug open, because there is still a lot of strings to unify across backends...

-- GitLab Migration Automatic Message --

This bug has been migrated to GNOME's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.gnome.org/GNOME/gvfs/issues/170.