Created attachment 195823 [details] [review]
gdm: replace 'gdm-password' with a constant

It's a little messy to have 'gdm-password' strung all
through the code, so this commit defines a constant up
top and uses that instead.

Created attachment 195824 [details] [review]
gdm: add fingerprint support

This commit adds the ability to log in with a fingerprint instead
of a password (assuming the user is enrolled and fingerprint
isn't disabled via gsettings)

These patches apply on top of the patch in bug 658062 just because they would duplicate work, otherwise.  They aren't inseparable though.

Comment on attachment 195824 [details] [review]
gdm: add fingerprint support


>diff --git a/data/org.gnome.shell.login-screen.gschema.xml.in b/data/org.gnome.shell.login-screen.gschema.xml.in

same comment as in the other bug. In particular, you presumably want to have the same setting for regular and fallback login screens.

>+	gdm/fprint.js		\

can you call it fingerprint.js? more obvious. (The object inside can still be Fprint, to match the dbus service name.)

>+        this._promptFingerprintMessage = new St.Label({ text: _("(or swipe finger)"),

maybe want a translation comment


I didn't test, but I'm assuming you got the logic right

Comment on attachment 195823 [details] [review]
gdm: replace 'gdm-password' with a constant

Attachment 195823 [details] pushed as 700f7fb - gdm: replace 'gdm-password' with a constant

I put the schema in GDM and pushed.

Attachment 195824 [details] pushed as 43f1d05 - gdm: add fingerprint support