After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 657818 - Prevent haze to be used for irc
Prevent haze to be used for irc
Status: RESOLVED FIXED
Product: empathy
Classification: Core
Component: General
3.1.x
Other Linux
: Normal normal
: ---
Assigned To: empathy-maint
empathy-maint
Depends on:
Blocks:
 
 
Reported: 2011-08-31 13:23 UTC by Alban Browaeys
Modified: 2011-09-06 16:50 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
prevent haze to get used to handle irc accounts on import. (1.01 KB, patch)
2011-08-31 13:23 UTC, Alban Browaeys 		reviewed Details | Review
rework avoid haze irc (1000 bytes, patch)
2011-09-06 13:23 UTC, Alban Browaeys 		committed Details | Review

Description Alban Browaeys 2011-08-31 13:23:00 UTC 
Created attachment 195293 [details] [review]
prevent haze to get used to handle irc accounts on import.

When using import from pidgin and telepathy-idle is not installed, haze might end up behing used to handle irc accounts.
This patches makes the import process ignore irc accounts if haze is the only irc connection manager available.
Comment 1 Guillaume Desmottes 2011-09-01 13:10:54 UTC 
Review of attachment 195293 [details] [review]:

Thanks a lot for your patch.

It looks good but I think the following will make the code clearer:

      if (tp_connection_manager_has_protocol (tp_cm,
          (const gchar*) protocol))
        {
          /* We don't want to use Haze for irc */
          if (!tp_strdiff (protocol, "irc") &&
              !tp_strdiff (tp_cm->name, "haze"))
            continue;

What do you think? Would you mind testing it and cook a new patch? :)
Comment 2 Alban Browaeys 2011-09-06 13:23:34 UTC 
Created attachment 195779 [details] [review]
rework avoid haze irc 

I also found the previous patch to lack obviousness . THank you for the quick fix.
Comment 3 Alban Browaeys 2011-09-06 13:29:03 UTC 
Forgot to tell . I tested it with and without telepathy-idle. Works well.
Comment 4 Guillaume Desmottes 2011-09-06 16:49:38 UTC 
Awesome, thanks ! I'm going to merge it.