After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 657670 - some axes label/ticks issues
some axes label/ticks issues
Status: RESOLVED FIXED
Product: Gnumeric
Classification: Applications
Component: Charting
git master
Other Linux
: Normal normal
: ---
Assigned To: Jean Bréfort
Jody Goldberg
Depends on:
Blocks:
 
 
Reported: 2011-08-30 07:06 UTC by Andreas J. Guelzow
Modified: 2011-08-31 03:21 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
sample file (16.58 KB, application/gnumeric)
2011-08-30 07:06 UTC, Andreas J. Guelzow
Details

Description Andreas J. Guelzow 2011-08-30 07:06:48 UTC
Created attachment 195156 [details]
sample file

Open the attached file and consider the image. There are 2 issues:

Ticks: there appears to be a minor tick missing. I think ther should be 3 of them between two consecutive major ticks, not just 2.

Label alignment: the fraction rendering aligns the fractions properly on top of each other as shown in the first two columns. For the axes labels of the horizontal axis this is not desired. (Note that the labels are offset to teh left since they really have empty space on their left.) I think the rendered values should be trimmed, by removing any regular space characters on the right (and deleting the corresponding pango attributes that create the correct width.)
Comment 1 Andreas J. Guelzow 2011-08-30 07:10:10 UTC
Note that the ticks are the main issue. For the labels in this case a user could change their format by unchecking "Show separate integer part" and choosing a minimum number of denominator digits of 0. This would create smaller labels.
Comment 2 Jean Bréfort 2011-08-30 14:00:28 UTC
The tick issue is a rounding error. I'll push a fix later today. Anyway, the labels issue is quite weird, even for the Y-axis where the 0 is ways too far on the left (as it is for the x axis).
Comment 3 Andreas J. Guelzow 2011-08-30 14:21:27 UTC
the label issue isn't weird. The label is of the form  x pi + y pi/z with x, y, z numbers. Rendering lines up the pi:

2 pi + 3 pi/4
0 pi + 0 pi/1
4 pi + 0 pi/1
0 pi + 3 pi/4

simplification changes this to:

2 pi + 3 pi/4
0
4 pi
       3 pi/4

the format specification controls the kind of simplification that happens,
Comment 4 Jean Bréfort 2011-08-30 14:29:12 UTC
What's weird is that space is reserved for missing fields, making the labels look misplaced.
Comment 5 Andreas J. Guelzow 2011-08-30 14:36:35 UTC
It's the dual use of the rendering. For columns of data you want things to line up.  You can get similar effects for formats such as 0.???????? where 0 also moves to the left.

For use as labels the rendered string needs to be trimmed on both sides. I can make up a patch for that.
Comment 6 Jean Bréfort 2011-08-30 15:03:51 UTC
Hmm, how does this work?.
Comment 7 Jean Bréfort 2011-08-30 16:01:55 UTC
Minor ticks fixed.
Comment 8 Andreas J. Guelzow 2011-08-31 03:21:25 UTC
This problem has been fixed in the development version. The fix will be available in the next major software release. Thank you for your bug report.