After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 657473 - Remove 24h combobox
Remove 24h combobox
Status: RESOLVED FIXED
Product: gnome-control-center
Classification: Core
Component: Date and Time
git master
Other Linux
: Normal normal
: ---
Assigned To: Control-Center Maintainers
Control-Center Maintainers
Depends on: 640059 644658 697498
Blocks:
 
 
Reported: 2011-08-26 20:20 UTC by Bastien Nocera
Modified: 2018-05-04 06:58 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
datetime: Do not offer the 12 hr clock in locales without AM/PM (2.66 KB, patch)
2012-04-14 19:05 UTC, Debarshi Ray
rejected Details | Review

Description Bastien Nocera 2011-08-26 20:20:34 UTC
+++ This bug was initially created as a clone of Bug #640059 +++

The switched we had before bug 640059 was causing problems because for many locales, there's no "opposite" to 24h time display:
http://en.wikipedia.org/wiki/Ante_Meridiem#Use_by_country

When the opposite of 24h can be effectively displayed, we can use a GtkSwitch again:
http://gitorious.org/gnome-design/gnome-design/blobs/master/mockups/theming/switches.png
Comment 1 rockonthemoonfm 2011-12-18 12:26:27 UTC
I agree.
 
for ex. I live in France, my City is set to Paris: we use 24h format, no reason to user-define time format.

If my timezone city was set to London, there is no reason to change a default format from AM/PM.
Comment 2 Hylke Bons 2011-12-18 12:48:14 UTC
(In reply to comment #1)
> I agree.
> 
> for ex. I live in France, my City is set to Paris: we use 24h format, no reason
> to user-define time format.
> 
> If my timezone city was set to London, there is no reason to change a default
> format from AM/PM.

People can live in different countries from where they were born you know.
Comment 3 rockonthemoonfm 2011-12-18 13:09:23 UTC
you mean.. like me?

I've already switched my timezone, even if I didn't need to switch hour format accordingly - not thanks to an automatically geolocation service. 
Turning AM/PM//24H switch into "Use geolocaiton" ON/OFF would be much more valuable, isn't it?

Here in France teatime is not at 5PM, but at 17. Actually it's apero time. :o)
Comment 4 Hylke Bons 2011-12-18 13:13:37 UTC
(In reply to comment #3)
> you mean.. like me?
>

Sorry, I assumed wrong :)
 
> I've already switched my timezone, even if I didn't need to switch hour format
> accordingly - not thanks to an automatically geolocation service. 
> Turning AM/PM//24H switch into "Use geolocaiton" ON/OFF would be much more
> valuable, isn't it?
> 
> Here in France teatime is not at 5PM, but at 17. Actually it's apero time. :o)

Date and time formats are a localisation preference and should be kept.
I hate the AM/PM format and live in England where that's mostly used (but not exclusively).

<rant>
The 24 hour clock is obviously superior.
</rant> :)
Comment 5 Debarshi Ray 2012-04-14 19:05:21 UTC
Created attachment 212055 [details] [review]
datetime: Do not offer the 12 hr clock in locales without AM/PM

Should we sanity check the GSettings key for cases where it has been set to the 12 hr clock in non-12 hr locales?
Comment 6 Bastien Nocera 2012-04-16 14:02:36 UTC
(In reply to comment #5)
> Created an attachment (id=212055) [details] [review]
> datetime: Do not offer the 12 hr clock in locales without AM/PM
> 
> Should we sanity check the GSettings key for cases where it has been set to the
> 12 hr clock in non-12 hr locales?

That's not what this bug is about. There are locales where AM/PM isn't used but people would still want 12h time. The bug will stay open until we can get a switch that can show the opposite values, as per mockup.
Comment 7 Debarshi Ray 2012-04-19 17:01:35 UTC
(In reply to comment #6)
> That's not what this bug is about. There are locales where AM/PM isn't used but
> people would still want 12h time. The bug will stay open until we can get a
> switch that can show the opposite values, as per mockup.

I misunderstood that this is related to:
https://bugzilla.gnome.org/show_bug.cgi?id=673721
Comment 8 Allan Day 2013-04-20 13:29:14 UTC
While it might be technically correct to show each of the possible settings in this case, I'm not convinced that it's that big of a deal. Using a switch with an appropriate label should give a user the context that they need, and it's easy to experiment with the setting to see what it does. (Also, using the locale to determine the default should get us most of the way towards a good solution anyway.)

The mockups for the Date & Time redesign use a switch: https://live.gnome.org/Design/SystemSettings/DateAndTime#Guidelines

That should be OK, so I'm closing this as not a bug.

That said, if there is a strong feeling that a switch isn't OK, we could use a combobox instead - just reopen the bug in that case, or make comments.

Either way, I don't think that we need to wait for improvements to the switch widget for this.
Comment 9 Bastien Nocera 2013-04-20 14:44:28 UTC
I didn't like the switch then, didn't like the switch now. There's no "opposite" to 24-hour format, so using a switch for that is wrong. I think we should something like the "switch with icons":
http://gitorious.org/gnome-design/gnome-design/blobs/master/mockups/theming/switches.png

24h [O=] 12h
Comment 10 Jean-François Fortin Tam 2013-04-20 15:55:49 UTC
Bastien's idea is along the same lines as my bug #697498 - great minds think alike? ;) I'm not entirely sure whether that's considered a GTK bug or the theme's responsibility.
Comment 11 Allan Day 2013-04-20 18:51:09 UTC
Looking at the new designs, a switch with labels on either side won't work in terms of layout. A combobox would:

+-----------------------------------------+
|                                         |
|                        +-------------+  |
| Time Format            | AM / PM   V |  |
|                        +-------------+  |
|                                         |
+-----------------------------------------+

I can update the mockups to use this.
Comment 12 Bastien Nocera 2013-04-23 14:58:49 UTC
A combobox with 2 items? At this rate, we might just as well keep the radio buttons :)
Comment 13 Kalev Lember 2013-08-24 18:33:24 UTC
Now that the date & time panel redesign landed last week, we've switched to using a combobox for choosing between 12h and 24h formats.

This problem has been fixed in the development version. The fix will be available in the next major software release. Thank you for your bug report.
Comment 14 Bastien Nocera 2013-08-24 19:51:51 UTC
Reopening, the combo boxes aren't liked either :)

The blocker bugs show what kind of widgets we'd use instead.
Comment 15 Kalev Lember 2018-05-04 06:58:11 UTC
Let's close this. The combobox matches the mockups that got implemented, nothing more to do here.