After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 657178 - configure bug - ac_save_CPPFLAGS trampled
configure bug - ac_save_CPPFLAGS trampled
Status: RESOLVED FIXED
Product: gnome-settings-daemon
Classification: Core
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: gnome-settings-daemon-maint
gnome-settings-daemon-maint
Depends on:
Blocks:
 
 
Reported: 2011-08-23 16:56 UTC by George McCollister
Modified: 2011-09-07 14:44 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
visual representation of the problem (83.46 KB, image/png)
2011-08-23 16:56 UTC, George McCollister 		  Details
build: Clean up X11 library dependencies (17.46 KB, patch)
2011-09-07 14:36 UTC, Bastien Nocera 		committed Details | Review

Description George McCollister 2011-08-23 16:56:31 UTC 
Created attachment 194498 [details]
visual representation of the problem

AC_CHECK_X_LIB and AC_CHECK_X_HEADERS are used in a nested manner. This results in ac_save_CPPFLAGS being overwritten. The end result is that -I$includedir bleeds into CPPFLAGS. This is causing host header files to be used when cross compiling to a different target. $includedir is supposed to be a destination directory not a source directory so I'm not sure why its being used here anyway.

I'm trying to cross compile gnome-settings-daemon 2.28.2 but the problem still appears to exist in the git master.
Comment 1 Bastien Nocera 2011-09-07 14:36:12 UTC 
Created attachment 195880 [details] [review]
build: Clean up X11 library dependencies

And make them per-plugin instead of as broad as before.
Comment 2 Bastien Nocera 2011-09-07 14:44:51 UTC 
Attachment 195880 [details] pushed as 34bf5fc - build: Clean up X11 library dependencies