After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 657092 - Split nm-applet dialogs into a separate library
Split nm-applet dialogs into a separate library
Status: RESOLVED FIXED
Product: NetworkManager
Classification: Platform
Component: nm-applet
git master
Other Linux
: Normal normal
: ---
Assigned To: Dan Williams
Dan Williams
Depends on:
Blocks: 650244 657093
 
 
Reported: 2011-08-22 16:55 UTC by Giovanni Campagna
Modified: 2011-08-26 20:51 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Split wireless and mobile wizard dialogs in a separate library (41.72 KB, patch)
2011-08-22 16:55 UTC, Giovanni Campagna 		none Details | Review

Description Giovanni Campagna 2011-08-22 16:55:00 UTC 
nm-applet currently shows dialogs for wireless and mobile (on behalf of gnome-shell and gnome-control-center) using a private dbus interface. This is not possible anymore for 3.2, as soon gnome-shell will conflict with nm-applet and prevent it from running.
I've prepared a patch that splits those dialogs in a libnm-gtk library, to be used by the control center. For now, only the wireless dialog (dialog of doom) and the mobile wizard are affected; in the future we can consider moving some more widgets in the library, as well as cleaning it up for public use.
Comment 1 Giovanni Campagna 2011-08-22 16:55:39 UTC 
Created attachment 194390 [details] [review]
Split wireless and mobile wizard dialogs in a separate library

Introduce a new libnm-gtk library, that will be used by
gnome-control-center to replace the nm-applet dbus methods.
Comment 2 Dan Williams 2011-08-22 22:56:52 UTC 
Not a bad approach, but I'd want to make sure this is actually private API shared between the applet and the shell somehow, and not public consumer API in any way.  Lets wait on this a few days until I cut 0.9 and then we can roll it in.
Comment 3 Matthias Clasen 2011-08-24 22:26:30 UTC 
0.9 has been cut. Any update on reviewing this ?

Sorry for the pushing, but we are on rather short deadlines to land shell features here.
Comment 4 Dan Williams 2011-08-26 20:51:48 UTC 
Fixed up to pass 'make distcheck' (srcdir vs. builddir thing) and to fix up po/POTFILES.in to point to the new files and pushed, thanks!