GNOME Bugzilla – Bug 657033
kate: emit timed metadata as tags
Last modified: 2011-08-23 08:35:20 UTC
Created attachment 194328 [details] [review] emit timed metadata as tags Metadata attached to other objects that may be used in this event are not passed, as is binary metadata.
+ return !*value; This appears to read past the end of the array. If this is correct, it is counterintuitive, so should be commented. Also, please use standard string functions whenever possible.
Created attachment 194345 [details] [review] use memchr instead of custom loop
Ah, it would indeed for a buffer entirely made of zeroes, as this would pass the validate call. Now using memchr, which I didn't think about before, and reorder tests to move the most expensive last. Though I'm having second thoughts on this. What I really want is buffer metadata, which aren't in 0.10, so tags are a fallback way of exposing this, but I'll think some more about it. (Hmm, it seems comments are dumped when also attaching a file, reposting)
commit d1a6ca22033060ae22f58d08b2eef7586868d92f Author: Vincent Penquerc'h <ogg.k.ogg.k@googlemail.com> Date: Sun Aug 21 20:36:07 2011 +0100 kate: pass on timed event metadata as tags when we can Metadata attached to other objects that may be used in this event are not passed, as is binary metadata.