GNOME Bugzilla – Bug 656419
[PATCH] minor refactoring in tracker-extract-gstreamer
Last modified: 2011-08-12 19:08:10 UTC
These patches fix a couple of compile warnings, and add a replace_double_gst_tag() function which factors out a pattern that was used twice
Created attachment 193719 [details] [review] tracker-extract-gstreamer: Tiny refactor
Created attachment 193721 [details] [review] tracker-extract-gstreamer: Fix compile warning
Created attachment 193722 [details] [review] tracker-extract-gstreamer: Remove unused functions
Comment on attachment 193719 [details] [review] tracker-extract-gstreamer: Tiny refactor Only two nit-pick comments here: + if (! has_it) + return; We don't usually use a space between the bang and variable. + gdouble value; + gboolean has_it; We don't align variables any more either. But great patch other than that. These two are too insignificant to change though ;)
Comment on attachment 193721 [details] [review] tracker-extract-gstreamer: Fix compile warning Nice patch :)
Comment on attachment 193722 [details] [review] tracker-extract-gstreamer: Remove unused functions Yea, I've been wondering about removing these functions since I started seeing the warnings too. Makes sense in the end I think. Thanks.
Usually we add "Fixes GB#123456" somewhere in a commit so we know when the bug is fixed and it gets picked up in the next release. http://live.gnome.org/Tracker/Documentation/GitCommitPolicy Did you intend to submit any more patches or can we close this bug? Thanks for the work here, it's appreciated!
Thanks, I'm done with this bug. I'll bear in mind your comments for next time :)