After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 656392 - audioresample: add FFT based checks
audioresample: add FFT based checks
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-base
unspecified
Other All
: Normal normal
: 0.10.36
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2011-08-12 11:11 UTC by Vincent Penquerc'h
Modified: 2011-08-16 11:30 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
audioresample: add FFT based checks (12.46 KB, patch)
2011-08-12 11:11 UTC, Vincent Penquerc'h 		none Details | Review
Amended for comments: (14.02 KB, patch)
2011-08-12 14:02 UTC, Vincent Penquerc'h 		committed Details | Review

Description Vincent Penquerc'h 2011-08-12 11:11:41 UTC 
As requested earlier.
The checks are pretty basic, but comparing FFTs of different sizes
proved difficult (I tried doing some linear filtering to bring FFTs
to the same size, but the value changes are so sudden I'd need to
smooth a lot to avoid false negatives, which would make the test
be very prone to false positives. There may be techniques for doing
this kind of thing, but I'm FFT ignorant so comments welcome).
Comment 1 Vincent Penquerc'h 2011-08-12 11:11:44 UTC 
Created attachment 193686 [details] [review]
audioresample: add FFT based checks

Send a few simple tones through audioresample and check
that the main frequency spot is the same for the input and
the resampled output.
Comment 2 Vincent Penquerc'h 2011-08-12 14:02:48 UTC 
Created attachment 193694 [details] [review]
Amended for comments:

- merge the three macros
- add a check that magnitude is about zero away from the hot spot
Comment 3 Sebastian Dröge (slomo) 2011-08-16 06:16:24 UTC 
commit 505bae099e60b391dc97bc55039178610f5736ea
Author: Vincent Penquerc'h <vincent.penquerch@collabora.co.uk>
Date:   Fri Aug 12 12:07:32 2011 +0100

    audioresample: add FFT based checks
    
    Send a few simple tones through audioresample and check
    that the main frequency spot is the same for the input and
    the resampled output.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=656392
Comment 4 Stefan Sauer (gstreamer, gtkdoc dev) 2011-08-16 11:30:08 UTC 
awesome