GNOME Bugzilla – Bug 656376
Support for delegation
Last modified: 2012-08-03 09:58:53 UTC
owa connector (Exchange 2003 provider) has delegation feature. It will be good to have feature parity.
Created attachment 198298 [details] [review] Patch for evolution-ews The patch is for get_delegate api. along with its test case.
Review of attachment 198298 [details] [review]: Please fix the mentioned comments and commit the patch. Thanks!! ::: src/server/e-ews-connection.c @@ +4102,3 @@ + data->user_id = g_new0(EwsUserId, 1); + if(data->user_id == NULL) + g_print("NULL value"); should it be a warning ? and can one proceed further if user_id is NULL ? @@ +4112,3 @@ + + child = e_soap_parameter_get_first_child_by_name(subparam, "PrimarySmtpAddress"); + data->user_id->primary_smtp_add = g_strdup(e_soap_parameter_get_string_value(child)); do not need to strdup it, the memory returned by e_soap_ api is already owned by the caller. @@ +4144,3 @@ + data->meetingcopies = TRUE; + else + data->meetingcopies = FALSE; else part can be removed. ::: src/server/e-ews-connection.h @@ +129,3 @@ + REVIEWER, + AUTHOR, + CUSTOM could be prefixed with EWS_PERM_ ::: src/server/tests/test-getdelegate.c @@ +47,3 @@ + e_ews_connection_get_delegate_finish (cnc, res, &get_delegate, + &error); + Free the get_delegate struct contents
Comment on attachment 198298 [details] [review] Patch for evolution-ews worked on review comments and created commit c9501f7 on master.
This change seems to introduce new compiler warnings: In file included from e-ews-connection.c:35:0: e-ews-connection.h:167:1: warning: parameter names (without types) in function declaration [enabled by default] In file included from e-ews-item.c:34:0: e-ews-connection.h:167:1: warning: parameter names (without types) in function declaration [enabled by default] In file included from ews-camel-common.h:24:0, from ews-camel-common.c:28: ../../src/server/e-ews-connection.h:167:1: warning: parameter names (without types) in function declaration [enabled by default] In file included from camel-ews-folder.c:47:0: ../../src/server/e-ews-connection.h:167:1: warning: parameter names (without types) in function declaration [enabled by default] In file included from camel-ews-store.h:29:0, from camel-ews-store.c:45: ../../src/server/e-ews-connection.h:167:1: warning: parameter names (without types) in function declaration [enabled by default] In file included from camel-ews-store.h:29:0, from camel-ews-provider.c:36: ../../src/server/e-ews-connection.h:167:1: warning: parameter names (without types) in function declaration [enabled by default] In file included from camel-ews-utils.h:24:0, from camel-ews-utils.c:34: ../../src/server/e-ews-connection.h:167:1: warning: parameter names (without types) in function declaration [enabled by default] In file included from camel-ews-store.h:29:0, from camel-ews-transport.c:34: ../../src/server/e-ews-connection.h:167:1: warning: parameter names (without types) in function declaration [enabled by default] In file included from exchange-ews-account-setup.c:42:0: ../../src/server/e-ews-connection.h:167:1: warning: parameter names (without types) in function declaration [enabled by default] In file included from ../../src/camel/camel-ews-utils.h:24:0, from exchange-ews-account-listener.c:35: ../../src/server/e-ews-connection.h:167:1: warning: parameter names (without types) in function declaration [enabled by default] In file included from e-cal-backend-ews.h:25:0, from e-cal-backend-ews-factory.c:15: ../../src/server/e-ews-connection.h:167:1: warning: parameter names (without types) in function declaration [enabled by default] In file included from ../../src/utils/ews-camel-common.h:24:0, from e-cal-backend-ews.c:44: ../../src/server/e-ews-connection.h:167:1: warning: parameter names (without types) in function declaration [enabled by default] In file included from e-cal-backend-ews-utils.c:35:0: ../../src/server/e-ews-connection.h:167:1: warning: parameter names (without types) in function declaration [enabled by default] In file included from e-book-backend-ews.c:55:0: ../../src/server/e-ews-connection.h:167:1: warning: parameter names (without types) in function declaration [enabled by default]
I was also getting this fixed in the following commit : http://git.gnome.org/browse/evolution-ews/commit/?id=836a1b26e70502197ef878afee193334e2b0aa33
Thanks, works for me. I'm closing the bug report.
My mistake will take care next time. Reopening it as need to add plugin part and add_delegate and remove_delegate api's too.
Fixed in commit 7ee6fd6 in ews master (3.5.5+)