After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 656334 - MetaWindowActor: Fix incorrect short-circuit
MetaWindowActor: Fix incorrect short-circuit
Status: RESOLVED FIXED
Product: mutter
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: mutter-maint
mutter-maint
Depends on:
Blocks:
 
 
Reported: 2011-08-11 11:13 UTC by Jasper St. Pierre (not reading bugmail)
Modified: 2011-08-26 17:07 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
MetaWindowActor: Fix incorrect short-circuit (2.71 KB, patch)
2011-08-11 11:13 UTC, Jasper St. Pierre (not reading bugmail) 		committed Details | Review

Description Jasper St. Pierre (not reading bugmail) 2011-08-11 11:13:45 UTC 
One of the bugs for mutter after 644930 landed.
Comment 1 Jasper St. Pierre (not reading bugmail) 2011-08-11 11:13:47 UTC 
Created attachment 193630 [details] [review]
MetaWindowActor: Fix incorrect short-circuit

The code here was wrong in every way: it only updated the shape if all the
borders changed. It never saved new last_borders even if it *had* changed,
and the bounding rectangle's x and y positions were still important otherwise.

This had user-visible impact when doing simple things like changing the
border_width. It would short-circuit here and due to the above incorrectness,
weirdness could happen where windows would be cut off and so on.
Comment 2 Jasper St. Pierre (not reading bugmail) 2011-08-26 17:07:12 UTC 
Attachment 193630 [details] pushed as 46415bb - MetaWindowActor: Fix incorrect short-circuit
Comment 3 Jasper St. Pierre (not reading bugmail) 2011-08-26 17:07:59 UTC 
Oops. Pushed by accident.