After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 656223 - GtkToolShell: Move vfunc default results to default implementations
GtkToolShell: Move vfunc default results to default implementations
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: Widget: GtkToolbar
3.1.x
Other Linux
: Normal normal
: ---
Assigned To: gtk-bugs
gtk-bugs
Depends on:
Blocks:
 
 
Reported: 2011-08-09 15:01 UTC by Murray Cumming
Modified: 2011-08-30 13:28 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
0001-GtkToolShell-Move-vfunc-default-results-to-default-i.patch (3.50 KB, patch)
2011-08-09 15:02 UTC, Murray Cumming
none Details | Review

Description Murray Cumming 2011-08-09 15:01:53 UTC
From the patch's commit message:

GtkToolShell: Move vfunc default results to default implementations.
    
    Otherwise the default values are only used if no vfunc is set,
    making that default unavailable to vfunc implementations as a fallback,
    and unavailable to language bindings (such as gtkmm) that always
    have a vfunc implementation, even if that often only tries to call
    the base vfunc implemntation.
    
    This was making gtkmm's ToolPalette's (and probably ToolBar's)
    items look like buttons instead of being flat.

OK to push?
Comment 1 Murray Cumming 2011-08-09 15:02:46 UTC
Created attachment 193493 [details] [review]
0001-GtkToolShell-Move-vfunc-default-results-to-default-i.patch
Comment 2 Murray Cumming 2011-08-25 08:02:15 UTC
May I please push this? It's very simple, obviously correct, and it makes a difference to me.
Comment 3 Murray Cumming 2011-08-30 13:28:46 UTC
Pushed after Matthias Clasen approved it on irc.