After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 656142 - URL Highlighting can catch "invisible" URLs
URL Highlighting can catch "invisible" URLs
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: message-tray
unspecified
Other Linux
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2011-08-08 07:44 UTC by Jasper St. Pierre (not reading bugmail)
Modified: 2011-09-02 21:23 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
messageTray: Don't try to URL highlight an invisible actor (2.37 KB, patch)
2011-08-29 23:30 UTC, Jasper St. Pierre (not reading bugmail)
committed Details | Review

Description Jasper St. Pierre (not reading bugmail) 2011-08-08 07:44:01 UTC
If you have a notification with a URL in expanded mode, if you move your mouse to the blank area to the right of the title... you can click on where the URL would be in banner mode to open the URL.
Comment 1 Jasper St. Pierre (not reading bugmail) 2011-08-29 23:30:37 UTC
Created attachment 195136 [details] [review]
messageTray: Don't try to URL highlight an invisible actor
Comment 2 Dan Winship 2011-08-30 17:10:54 UTC
Comment on attachment 195136 [details] [review]
messageTray: Don't try to URL highlight an invisible actor

hm... ok, although it might be nicer with an is_visible() method.

(It seems like maybe if the text can contain active content then we shouldn't just use opacity to hide it... but we can change that if we run into another problem later I guess)
Comment 3 Jasper St. Pierre (not reading bugmail) 2011-09-02 21:23:39 UTC
Attachment 195136 [details] pushed as b8d9273 - messageTray: Don't try to URL highlight an invisible actor


Dan said on IRC this is "good enough".