After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 655724 - egl-gdl: Don't generate cogl-display.h
egl-gdl: Don't generate cogl-display.h
Status: RESOLVED FIXED
Product: cogl
Classification: Platform
Component: EGL
unspecified
Other All
: Normal normal
: ---
Assigned To: Cogl maintainer(s)
Cogl maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2011-08-01 14:48 UTC by Damien Lespiau
Modified: 2011-08-01 15:41 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
egl-gdl: Don't generate cogl-display.h (2.57 KB, patch)
2011-08-01 14:48 UTC, Damien Lespiau
none Details | Review

Description Damien Lespiau 2011-08-01 14:48:21 UTC
It's not necessary to generate cogl-display.h just for the GDL backend
and to change the inclusion of libgdl.h. We can just tweak the include
CFLAGS to put /usr/include/CE4100 in the search path when needed.

Previously this did not work because of a stay ',' at the end of the
COGL_EXTRA_CFLAGS int he configure.ac. This actually simplifies the
code, which is always good.

This also fixes out of tree builds.
Comment 1 Damien Lespiau 2011-08-01 14:48:23 UTC
Created attachment 192986 [details] [review]
egl-gdl: Don't generate cogl-display.h
Comment 2 Neil Roberts 2011-08-01 15:41:28 UTC
Pushed as ee01fd263a94a36467bc320f8436681b48945439. Thanks.