GNOME Bugzilla – Bug 655212
Update for libfolks API changes to AvatarDetails
Last modified: 2011-08-16 08:22:47 UTC
Bug #650414 changes how avatars are handled in libfolks. Patch coming up to update Empathy accordingly. (Note that the patch in bug #650414 hasn't yet been committed, but it hopefully will be soon.)
Created attachment 192563 [details] [review] Update for libfolks API changes to AvatarDetails
Review of attachment 192563 [details] [review]: Looks fine to me, minus one style thing. Seriously though, why isn't there API to load a loadable icon into a GdkPixbufLoader, that seems like it would be useful, and cut out a lot of code (is that worth filing a bug to ask for?). ::: libempathy-gtk/empathy-ui-utils.c @@ +560,3 @@ { + g_object_unref (closure->cancellable); + tp_clear_object (&(closure->loader)); You don't need these brackets. -> binds more tightly than & and since we don't use brackets anywhere else, it makes this confusing to read.
(In reply to comment #2) > Review of attachment 192563 [details] [review]: > > Looks fine to me, minus one style thing. > > Seriously though, why isn't there API to load a loadable icon into a > GdkPixbufLoader, that seems like it would be useful, and cut out a lot of code > (is that worth filing a bug to ask for?). There's gdk_pixbuf_new_from_stream() which would be great, except it doesn't support the fine-grained scale control that GdkPixbufLoader::size-prepared gives us. I guess one tiny advantage of the approach we're forced to take is that we can bail earlier if the image header is corrupt/not recognised (and thus not read more of the input stream than necessary). > ::: libempathy-gtk/empathy-ui-utils.c > @@ +560,3 @@ > { > + g_object_unref (closure->cancellable); > + tp_clear_object (&(closure->loader)); > > You don't need these brackets. -> binds more tightly than & and since we don't > use brackets anywhere else, it makes this confusing to read. OK. I'll fix that before committing. Thanks.
Would be cool to fix this ASAP so Empathy 3.1 can use Folks 0.6
Patch works nicely for me. Philip: anything besides what has been pointed out in the comments that you'd like to see address before we push this?
(In reply to comment #5) > Patch works nicely for me. Philip: anything besides what has been pointed out > in the comments that you'd like to see address before we push this? Can't think of anything else. If nobody else gets there first, I'll tidy this up and push it tonight.
Merged to master.