After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 655101 - dnd from contact list to a chat should invite the contact to the chat
dnd from contact list to a chat should invite the contact to the chat
Status: RESOLVED FIXED
Product: empathy
Classification: Core
Component: Multi User Chat
3.1.x
Other Linux
: Normal enhancement
: 3.4
Assigned To: empathy-maint
Depends on:
Blocks:
 
 
Reported: 2011-07-22 08:48 UTC by Emilio Pozuelo Monfort
Modified: 2012-02-17 14:24 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
chat-window: invite contacts using DnD (4.01 KB, patch)
2012-02-17 14:14 UTC, Guillaume Desmottes 		committed Details | Review

Description Emilio Pozuelo Monfort 2011-07-22 08:48:37 UTC 
We used to support dragging contacts from the CL to a MUC to add them to that room (see e.g. bug #595180), but that doesn't work anymore.
Comment 1 Guillaume Desmottes 2011-09-08 14:40:04 UTC 
Actually we never supported that. What we did support was DnD from the contact list to a chat window to start a *new* chat with this contact, and that's indeed broken (since the port to Folks).

But I agree with you, we should invite it to the current chat instead.
Comment 2 Guillaume Desmottes 2011-09-12 10:03:20 UTC 
I implemented this but I'm blocked by bug #658576

Basically we need a way to fetch the FolksIndividual and, atm, the only way is
to fetch all the individuals which is not great from a perf pov.
Comment 3 Guillaume Desmottes 2011-09-15 10:01:58 UTC 
Looks like this won't happen for 3.2 as we need change in Folks to do this properly.
Comment 4 Guillaume Desmottes 2012-02-17 14:13:23 UTC 
(In reply to comment #2)
> I implemented this but I'm blocked by bug #658576
> 
> Basically we need a way to fetch the FolksIndividual and, atm, the only way is
> to fetch all the individuals which is not great from a perf pov.

This is no longer a problem as empathy-chat now keeps the individual manager while running.
Comment 5 Guillaume Desmottes 2012-02-17 14:14:05 UTC 
Created attachment 207853 [details] [review]
chat-window: invite contacts using DnD
Comment 6 Will Thompson 2012-02-17 14:18:50 UTC 
Review of attachment 207853 [details] [review]:

Nice! This looks fine to me.
Comment 7 Guillaume Desmottes 2012-02-17 14:24:44 UTC 
Attachment 207853 [details] pushed as 9be0890 - chat-window: invite contacts using DnD